Use configured npm registry for publish checks - #11519
Closed
chidozieononiwu wants to merge 1 commit into
Closed
Conversation
chidozieononiwu
requested review from
catalinaperalta,
iscai-msft,
markcowl,
timotheeguerin and
xirzec
as code owners
July 31, 2026 23:33
Contributor
|
No changes needing a change description found. |
|
You can try these changes here
|
|
|
||
| // Check if the specific version exists in the versions object | ||
| return data.versions && version in data.versions; | ||
| await execAsync(`npm view "${name}@${version}" version --json`, { encoding: "utf8" }); |
Member
There was a problem hiding this comment.
Hhm I think this is not a solution, with the quarantine it might think some are not published even though they are. The whole purpose of this is to workaround the garbage of esrp not giving any info on what was published so we can figure out how other things are published
chidozieononiwu
force-pushed
the
use-devops-feed-for-publish-check-clean
branch
from
August 1, 2026 00:19
390c239 to
abbdba0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the way the script checks if a package version is published to npm. Instead of directly querying the npm registry via HTTP, it now uses the
npm viewCLI command, which respects the user's npm configuration and registry settings.Improvements to package publication check:
isPackagePublishedfunction infilter-unpublished-packages.tsnow usesnpm viewviaexecAsyncto check for published versions, ensuring compatibility with custom or private registries and aligning with user npm configuration.https://registry.npmjs.org/was removed, reducing manual error handling and potential mismatches with npm settings.