Skip workspace settings entries whose URI has no filesystem path - #87
Merged
Eduardo Villalpando Mello (edvilme) merged 2 commits intoAug 17, 2026
Conversation
Copilot started work on behalf of
Eduardo Villalpando Mello (edvilme)
August 17, 2026 23:21
View session
Co-authored-by: edvilme <5952839+edvilme@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix language-server initialization crash in mixed multi-root workspace
Skip workspace settings entries whose URI has no filesystem path
Aug 17, 2026
Eduardo Villalpando Mello (edvilme)
approved these changes
Aug 17, 2026
Eduardo Villalpando Mello (edvilme)
marked this pull request as ready for review
August 17, 2026 23:26
Eduardo Villalpando Mello (edvilme)
enabled auto-merge (squash)
August 17, 2026 23:29
Bill Schnurr (bschnurr)
approved these changes
Aug 17, 2026
Eduardo Villalpando Mello (edvilme)
merged commit Aug 17, 2026
28b4b4f
into
main
21 of 22 checks passed
Eduardo Villalpando Mello (edvilme)
deleted the
copilot/fix-workspace-initialization-crash
branch
August 17, 2026 23:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a mixed multi-root workspace (a local
file:folder plus a virtual root such as MicroPico'spico:),uris.to_fs_path("pico:")returnsNone, which flowed intonormalize_path()→pathlib.Path(None)and raisedTypeError, blocking initialization of the Pylint, Black, and isort servers.Changes
server.py—ToolServer.update_workspace_settings()now resolves the filesystem path into a local variable and skips entries where itis None;file:roots are registered unchanged.tests/test_server.py— regression test inTestUpdateWorkspaceSettingsfeedingfile:///local-workspace(mocked to/local-workspace) alongsidepico:(mocked toNone), asserting no raise, a single registered workspace, and itsworkspace/workspaceFSvalues.Scope
Deliberately limited to filesystem-based workspace registration. Document synchronization and stdin-based tool execution are untouched, so documents from a virtual root can still be delivered and processed by consuming language servers — they simply fall back to the existing cwd-based settings lookup rather than a workspace-specific entry. Virtual-filesystem mirroring is out of scope here.