Skip to content

Add inline script activation-time discovery (PEP 723 PR 8/16) #1722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Stella Huang (StellaHuang95) wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add inline script activation-time discovery (PEP 723 PR 8/16) #1722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
59c1815
Add inline script activation-time discovery
StellaHuang95 Aug 17, 2026
faa729f
Harden inline script activation discovery
StellaHuang95 Aug 18, 2026
a48066a
Clarify snapshot refresh promise flow
StellaHuang95 Aug 18, 2026
8383af0
Handle missing final discovery snapshot
StellaHuang95 Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/common/inlineScript/cacheLayout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ export function selectStaleEntries(entries: ReadonlyArray<CacheEntrySummary>, no
}

/**
* Verify that a cached env's base interpreter still exists on disk.
* Verify that a cached env's launcher and base interpreter still exist on disk.
*/
export async function verifyBaseInterpreterExists(envDir: Uri): Promise<boolean> {
return (await getBaseInterpreterStatus(envDir)) === 'available';
Expand All @@ -221,6 +221,11 @@ async function getPosixBaseInterpreterStatus(envDir: Uri): Promise<BaseInterpret
}

async function getWindowsBaseInterpreterStatus(envDir: Uri): Promise<BaseInterpreterStatus> {
const launcherStatus = await getRegularFileStatus(getVenvPythonPath(envDir.fsPath), 'cached interpreter launcher');
if (launcherStatus !== 'available') {
return launcherStatus;
}

const pyvenvPath = Uri.joinPath(envDir, 'pyvenv.cfg').fsPath;
let raw: string;
try {
Expand Down
Loading
Loading