Fix PIBD resume stall with newer archive target - #3932
Merged
Merged
Conversation
ardocrat
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PIBD could stop requesting output, rangeproof and kernel segments when
resuming against a newer archive target if both pmmr sizes were within the
same segment.
This could be fixed with three small changes, but the surrounding logic was
duplicated for all three pmmr. I moved it into a shared helper to keep the
behavior consistent and make it easier to test.
Tests cover the reported resume case, segment boundaries, completed targets
and Genesis (https://forum.grin.mw/t/grim-cross-platform-gui-for-grin/11128/115?u=wiesche).
Fixes #3931