Skip to content

chore: trim CODEOWNERS entries now enforced org-wide (ENG-2013) - #3

Merged
hamishfagg merged 1 commit into
mainfrom
hamish/eng-2013-remove-codeowners
Sep 11, 2026
Merged

hamishfagg merged 1 commit into
mainfrom
hamish/eng-2013-remove-codeowners

Conversation

@hamishfagg

@hamishfagg hamishfagg commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

What

Edits .github/CODEOWNERS. The org-level ruleset in mindsdb/terraform (newprod/global/github) requires a @mindsdb/devops review on the paths common to all repos, and enforces each repo's CODEOWNERS through require_code_owner_review. So: shared paths leave this file, repo-specific ones stay.

Removed:

/.github/workflows/ @mindsdb/devops
/docker/docker-bake.hcl @mindsdb/devops
/pyproject.toml @mindsdb/devops

Kept, as this repo's own rules (enforced by the org ruleset's require_code_owner_review):

/tests/scripts/ @mindsdb/devops

Why

One org-wide policy in terraform for what every repo shares; CODEOWNERS for what only this repo needs. Neither duplicates the other.

Targets main.

🤖 Generated with Claude Code

@hamishfagg
hamishfagg requested a review from a team September 10, 2026 02:37
@github-actions

github-actions Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Paths every repo shares (.github/, Dockerfile, Makefile, docker/, alembic/,
pyproject.toml, ...) now require a @mindsdb/devops review through the org-level
ruleset in mindsdb/terraform, so they leave this file. Anything specific to this
repo stays here; the same ruleset enforces CODEOWNERS via
require_code_owner_review.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@hamishfagg
hamishfagg force-pushed the hamish/eng-2013-remove-codeowners branch from bcc7a89 to b522e6a Compare September 10, 2026 05:07
@hamishfagg hamishfagg changed the title chore: trim CODEOWNERS, now enforced by the org ruleset (ENG-2013) chore: trim CODEOWNERS entries now enforced org-wide (ENG-2013) Sep 10, 2026

@lucas-koontz lucas-koontz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi: Reviewed the CODEOWNERS change at b522e6ab2a48. The active organization baseline covers the removed paths, and /tests/scripts/ remains assigned to DevOps. GitHub reports no CODEOWNERS errors. No blocking findings. The CLA check reports unsigned contributors; skipped deployment jobs do not validate this policy.

@hamishfagg

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request Sep 11, 2026
@hamishfagg
hamishfagg merged commit bd132e4 into main Sep 11, 2026
20 of 21 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 11, 2026

This branch had an error being deployed

3 failed deployments
alpha-dev — b522e6ab Deployed Sep 11, 2026 by hamishfagg via Deploy to Staging / migrate (alpha-dev) #2
staging — b522e6ab Deployed Sep 11, 2026 by hamishfagg via Deploy to Staging / migrate (staging) #2
dev — b522e6ab Deployed Sep 11, 2026 by hamishfagg via Deploy to Staging / migrate (dev) #2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants