chore: remove CODEOWNERS, now enforced by the org ruleset (ENG-2013) - #66
Closed
hamishfagg wants to merge 1 commit into
Closed
hamishfagg wants to merge 1 commit into
hamishfagg wants to merge 1 commit into
Conversation
Review of these paths by @mindsdb/devops is required and auto-requested by the org-level ruleset defined in mindsdb/terraform (newprod/global/github), so the file no longer adds anything. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
Author
|
Closing: with repo-specific review rules staying in CODEOWNERS, this file is still needed as-is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Deletes
.github/CODEOWNERS. Every removed entry named@mindsdb/devops, and each of those paths is now covered by an org-level ruleset (mindsdb/terraform#202): devops approval is required on them and the team is auto-requested as reviewer, the same as CODEOWNERS did.Removed:
Why
One review policy in terraform instead of 24 hand-maintained files. Keeping both would mean two mechanisms saying the same thing, and drift between them when one is edited.
Targets
main.🤖 Generated with Claude Code