argocd-pr-env-deploy: revision-only links for mindshub_services - #67
Merged
Merged
Conversation
mindshub_services deploys a SAM stack per PR env from a git revision and publishes no image, so `Deploys: mindshub_services#N` failed the ECR existence check. Such links now set revisions.<repo> to the PR head SHA and nothing else. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
mindsdb-devops
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Deploys: mindshub_services#Non an anchor PR resolves to--helm-set revisions.mindshub_services=<head sha>only, and a mindshub_services PR as the anchor itself gets the same: no ECR lookup, notags.<repo>. Oneis_revision_only_repohelper covers both.Why
mindshub_services ships a SAM stack, deployed per PR env by its
pr-env-stacksworkflow from the revision on the parent Application. It publishes no image, so the existing path hitRepositoryNotFoundExceptionand failed the deploy.Part of
Checks
bash -non the step script.Deploys: mindshub_services#stagingkeeps going through the generic staging branch, which also sets an unusedtags.mindshub_services; harmless.🤖 Generated with Claude Code