[Codex review] feat(message): add reply actions and quote previews - #1
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3b3d1fc9bf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <MessageAction | ||
| label={label} | ||
| onClick={handleClick} | ||
| onPointerCancel={handlePointerCancel} | ||
| onPointerDown={handlePointerDown} | ||
| {...props} | ||
| > | ||
| {children ?? <ReplyIcon className="size-4" />} |
There was a problem hiding this comment.
When a consumer supplies visible text as children without an explicit aria-label—for example, <MessageReply>Respond</MessageReply>—the default label="Reply" is still passed to MessageAction, which renders it in an additional sr-only span. The resulting accessible name is therefore “Respond Reply” rather than the visible label, causing duplicated or contradictory announcements for screen-reader users. This is especially likely because the documentation explicitly recommends passing children to customize the action.
Useful? React with 👍 / 👎.
1 participant
Companion review for vercel#492.
This pull request shares the upstream contribution's
codex/message-reply-356head branch. Follow-up fixes pushed to that branch update both pull requests.The base snapshots upstream
mainat6a9d5b1822ffb10bba4bd97175f01edd7d8651cd; the initial contribution head is3b3d1fc9bf44649efaa06704ade84071370cc906.This PR is for Codex review in the connected fork. The linked upstream PR remains the contribution target; leave this companion PR unmerged.