CI: pytest-xdist in every suite, real-mpirun tests rebalanced to the kvcache job; version 4.0.1 - #883
Merged
Merged
Conversation
…probe tests move to the kvcache job; matrix comments rebalanced from measured wall-clock
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI wall-clock has crept up to about 3:45 per run. The critical path was the
othersjob: its test step alone took 174s (main suite + package suite + vdb, serial), while thekvcachejob finished a minute earlier. Two things were true that the layout did not exploit: four real-mpirun tests are 35% of the main suite when run serially (a fixed ~10s quiesce window each), and both heavy suites parallelize cleanly.Changes
pytest-xdistadded to thetestextra (pyproject.toml,uv.lock). Every suite with more than a few seconds of work runs with-n auto(one worker per runner vCPU). No test code changed; both heavy suites were already xdist-clean.kvcacherunskv_cache_benchmark/teststhentests/integration/test_shared_fs_probe_real_mpi.py;othersrunstestswith that file--ignored, thenmlpstorage_py/tests, thenvdb_benchmark/tests. Every test still runs exactly once per workflow run; the comment in the workflow says so.3.0.46→4.0.1(pyproject.toml,uv.lock) — first release on the v4.0 line.RULES_EDITIONstays3.0(tool releases never bump the edition; see Rules.md "Rules editions and comparability classes").Measurements (this box, 4 workers = the runner's vCPU count)
-n 4testsminus real-MPIkv_cache_benchmark/testsmlpstorage_py/testsvdb_benchmark/testsStability: kvcache and the real-MPI file each ran 3× under 4 workers, clean every time. One kvcache test (
TestThreeTierEvictionCascade::test_demote_path_preserves_data) failed once earlier while this machine was running four serial pytest processes at once, and passed on every xdist run; noting it here as a test to watch if the kvcache job ever goes red.Expected CI: both jobs' test steps land around 40–60s, so the run should be bounded by setup (checkout, apt OpenMPI,
uv sync) plus about a minute, roughly 2:00 instead of 3:45.Not in this PR
setup-uvenable-cache: true, apt) would trim the ~45–60s setup further.ubuntu-latesthas 4); rewritten.