fix: read the TAR of 03.48 response packets at the right offset - #3
Merged
Merged
Conversation
A command packet (IEI 0x70) carries the TAR at offset 10, a response packet / Proof of Receipt (IEI 0x71) at offset 6, right after RPL and RHL. Add isResponsePacket, getResponsePacketTar, getPacketTar (IEI aware) and stripUdh. Version 1.0.23.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the RAM (applet install over the air) campaign work. Library version 1.0.23.
PacketUtil.getCommandPacketTarreads the TAR at offset 10, which is correct for a command packet (IEI 0x70: UDH, CPL, CHL, SPI, KIc, KID, TAR). A response packet / Proof of Receipt (IEI 0x71: UDH, RPL, RHL, TAR) carries the TAR at offset 6 (ETSI TS 102 225 section 5.2; etsi102225'sPacketBuilderImplplaces the response counters at offset 6 after the 3 byte TAR, i.e. TAR at 3 without UDH).Added, without changing existing methods:
isResponsePacket(msg)getResponsePacketTar(msg)getPacketTar(msg): picks the offset from the UDH IEI, null when the message is not a packetstripUdh(msg)Used by
mno-adapters-smpp-client(PoR classification) andmno-adapters-ustk(PoR decoding). Merge before those.