Dependency updates for v0.34 - #7228
Merged
Merged
Conversation
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Update shared modules to Moby's versions while keeping github.com/moby/go-archive at v0.2.0. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
github-actions
Bot
added
area/project
area/dependencies
jsternberg
approved these changes
Sep 30, 2026
jsternberg
left a comment
jsternberg
left a comment
Collaborator
There was a problem hiding this comment.
Dependency changes seem fine although I'm a bit confused why new linter errors popped up when I don't see the linter or go version having changed.
| }() | ||
| bklog.G(ctx).Debugf("serving grpc connection") | ||
| (&http2.Server{}).ServeConn(conn, &http2.ServeConnOpts{Handler: grpcServer}) | ||
| (&http2.Server{}).ServeConn(conn, &http2.ServeConnOpts{Handler: grpcServer}) //nolint:staticcheck // This existing HTTP/2 connection is already established. |
Collaborator
There was a problem hiding this comment.
I don't see a change in the linter dependencies so I'm a bit confused where this new lint comes from.
Member
Author
There was a problem hiding this comment.
I have no idea tbh but it fails without it
> [lint-labs golangci-lint 1/1] RUN --mount=target=/go/src/github.com/moby/buildkit --mount=target=/root/.cache,type=cache,id=lint-cache-labs-linux/arm64 xx-go --wrap && golangci-lint run --build-tags "" && touch /golangci-lint.done:
170.5 level=warning msg="[runner/exclusion_rules] Skipped 0 issues by rules: [Path: \".*\\\\.pb\\\\.go$\", Linters: \"gofmt, goimports\"]"
170.5 frontend/gateway/gateway.go:1766:2: SA1019: (&http2.Server{}).ServeConn is deprecated: Use [http.Server.Serve] or [http.Server.ServeTLS] instead. (staticcheck)
170.5 (&http2.Server{}).ServeConn(conn, &http2.ServeConnOpts{Handler: grpcServer})
170.5 ^
170.5 session/grpc.go:66:2: SA1019: (&http2.Server{}).ServeConn is deprecated: Use [http.Server.Serve] or [http.Server.ServeTLS] instead. (staticcheck)
170.5 (&http2.Server{}).ServeConn(conn, &http2.ServeConnOpts{Handler: grpcServer})
170.5 ^
170.5 2 issues:
170.5 * staticcheck: 2
maybe I have some cache mount leak messing up the linter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.