Avoid speaking of 'instance hierarchy'#3916
Open
henrikt-ma wants to merge 3 commits into
Open
Conversation
henrikt-ma
force-pushed
the
cleanup/instance-hierarchy
branch
from
104d263 to
acef07f
Compare
Collaborator
|
Maybe it would be a good idea to update the labels too, such as |
Collaborator
Yes, they should be consistent. |
HansOlsson
reviewed
Jun 8, 2026
HansOlsson
reviewed
Jun 9, 2026
Co-authored-by: Hans Olsson <HansOlsson@users.noreply.github.com>
Ok, good enough. Co-authored-by: Henrik Tidefelt <henrikt@wolfram.com>
HansOlsson
reviewed
Jun 29, 2026
|
|
||
|
|
||
| \section{Inner Declarations - Instance Hierarchy Name Lookup}\label{instance-hierarchy-name-lookup-of-inner-declarations}\label{inner-declarations-instance-hierarchy-name-lookup} | ||
| \section{Inner Declarations - Instance Tree Name Lookup}\label{instance-hierarchy-name-lookup-of-inner-declarations}\label{inner-declarations-instance-hierarchy-name-lookup} |
Collaborator
There was a problem hiding this comment.
Suggested change
| \section{Inner Declarations - Instance Tree Name Lookup}\label{instance-hierarchy-name-lookup-of-inner-declarations}\label{inner-declarations-instance-hierarchy-name-lookup} | |
| \section{Inner Declarations - Instance Tree Name Lookup}\label{instance-hierarchy-name-lookup-of-inner-declarations}\label{inner-declarations-instance-tree-name-lookup} |
Consistent name.
I'm aware that the double-label isn't working as intended (only one is present in html), so adding a third one wouldn't help, but removing the first one would require a change on line 592 as well.
HansOlsson
approved these changes
Jun 29, 2026
HansOlsson
left a comment
HansOlsson
left a comment
Collaborator
There was a problem hiding this comment.
Looks good except the label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing a few places where the term instance hierarchy was used, and where I believe the correct term to use is instance tree.