Clarify that package.order does not affect visibility#3923
Open
henrikt-ma wants to merge 1 commit into
Open
Conversation
f53b16c to
f89c0c2
Compare
HansOlsson
reviewed
Jun 29, 2026
Comment on lines
+229
to
+230
| Only elements defined in \filename{package.mo} are affected by the visibility control (\cref{access-control-public-and-protected-elements}) in \filename{package.mo}; the child classes defined in other files or directories always have public visibility. | ||
| In particular, reordering classes using \filename{package.order} has no impact on visibility. |
Collaborator
There was a problem hiding this comment.
The text is fine in itself. However, I had to check what and where it was already present and found:
All elements defined under the heading protected are regarded as protected. All other elements (i.e.,
defined under the heading public, without headings or in a separate file) are public (i.e., not protected).
So, perhaps we should make it clear that it was already defined (not exactly sure how to formulate):
Suggested change
| Only elements defined in \filename{package.mo} are affected by the visibility control (\cref{access-control-public-and-protected-elements}) in \filename{package.mo}; the child classes defined in other files or directories always have public visibility. | |
| In particular, reordering classes using \filename{package.order} has no impact on visibility. | |
| According to \cref{access-control-public-and-protected-elements} only elements defined in \filename{package.mo} are affected by the visibility control in \filename{package.mo}; the child classes defined in other files or directories always have public visibility. | |
| In particular, reordering classes using \filename{package.order} has no impact on visibility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing a small need for clarification encountered in relation to #3921.