Skip to content

Clarify that package.order does not affect visibility#3923

Open
henrikt-ma wants to merge 1 commit into
modelica:masterfrom
henrikt-ma:cleanup/package-order-visibility
Open

Clarify that package.order does not affect visibility#3923
henrikt-ma wants to merge 1 commit into
modelica:masterfrom
henrikt-ma:cleanup/package-order-visibility

Conversation

@henrikt-ma

Copy link
Copy Markdown
Collaborator

Addressing a small need for clarification encountered in relation to #3921.

@henrikt-ma henrikt-ma force-pushed the cleanup/package-order-visibility branch from f53b16c to f89c0c2 Compare June 24, 2026 08:11

@maltelenz maltelenz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me.

Comment thread chapters/packages.tex
Comment on lines +229 to +230
Only elements defined in \filename{package.mo} are affected by the visibility control (\cref{access-control-public-and-protected-elements}) in \filename{package.mo}; the child classes defined in other files or directories always have public visibility.
In particular, reordering classes using \filename{package.order} has no impact on visibility.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text is fine in itself. However, I had to check what and where it was already present and found:

https://specification.modelica.org/master/class-predefined-types-and-declarations.html#access-control-public-and-protected-elements

All elements defined under the heading protected are regarded as protected. All other elements (i.e.,
defined under the heading public, without headings or in a separate file) are public (i.e., not protected).

So, perhaps we should make it clear that it was already defined (not exactly sure how to formulate):

Suggested change
Only elements defined in \filename{package.mo} are affected by the visibility control (\cref{access-control-public-and-protected-elements}) in \filename{package.mo}; the child classes defined in other files or directories always have public visibility.
In particular, reordering classes using \filename{package.order} has no impact on visibility.
According to \cref{access-control-public-and-protected-elements} only elements defined in \filename{package.mo} are affected by the visibility control in \filename{package.mo}; the child classes defined in other files or directories always have public visibility.
In particular, reordering classes using \filename{package.order} has no impact on visibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants