Avoid speaking of file system entities#3924
Open
henrikt-ma wants to merge 1 commit into
Open
Conversation
henrikt-ma
force-pushed
the
cleanup/no-filesystem-entities
branch
from
69c6bc1 to
5a73a5a
Compare
henrikt-ma
force-pushed
the
cleanup/no-filesystem-entities
branch
from
5a73a5a to
1050016
Compare
HansOlsson
reviewed
Jun 29, 2026
|
|
||
| \begin{nonnormative} | ||
| A non-empty \lstinline!within!-clause only states redundant information, completely determined by the file location in the stored hierarchy rooted in the directory where the \filename{package.mo} has no or an empty \lstinline!within!-clause. | ||
| The redundant information is not only a convenience for tools and humans, it is also information needed to verify that \lstinline!Protection!-annotations (\Cref{modelica:Protection.access}) are not bypassed by moving an encrypted file to a different location in the class tree. |
Collaborator
There was a problem hiding this comment.
Suggested change
| The redundant information is not only a convenience for tools and humans, it is also information needed to verify that \lstinline!Protection!-annotations (\Cref{modelica:Protection.access}) are not bypassed by moving an encrypted file to a different location in the class tree. |
We have currently not defined whether encrypted files can be stored hierarchically, and I could see several issues with that (including the within-issues - but also other ones) that I don't think we should just add it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the File System Mapping of Package/Class section by avoiding introduction of the various "entity" terms. Instead, the new presentation is focused around the well known concepts of files and directories, with the addition of stored hierarchy for the part of the whole file system hierarchy that corresponds to a Modelica class.
This PR is meant to replace #3890, applying the idea that the language group agreed upon in #3890 (comment).