feat(theme): restore the original palette as the Classic theme#82
Open
tridha643 wants to merge 3 commits into
Open
feat(theme): restore the original palette as the Classic theme#82tridha643 wants to merge 3 commits into
tridha643 wants to merge 3 commits into
Conversation
A neutral cool-grey theme joins the board picker, with light and dark palettes derived from one Palette each like the other presets. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Replace the placeholder Graphite preset with the exact pre-theme-picker palette (warm paper / ink), reconstructed from styles.css + surfacePage tokens at commit 746b7e0^. shiki github-light/github-dark, matching the original markdown/diff highlighting. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
tridha643
changed the title
First-time loads (no stored setting) now resolve to Classic; an explicit pick is still persisted per board and takes precedence. themeById falls back to the configured default instead of the first registry entry. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Member
|
So my issue is the classic theme doesn't have a good matching shiki code syntax theme - and without both, if you render diffs and code blocks on the same page it looks bad. Find a better fit than github-dark, show some screenshots of everything on one page, then can evaluate properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
746b7e0).viewer/src/styles.cssand the agent-facing--color-*tokens fromserver/surfacePage.tsat746b7e0^. Syntax highlighting usesgithub-light/github-dark, matching the original markdown/diff rendering.How it looks
Classic selected in the picker (dark): warm
#1f1e1bchrome, ink-on-paper text, the original blue/green/amber/red accents.Note on the data model
The pre-picker styles defined three border levels; the current
Palettecollapses them to two (border+border2), so the html-part--color-border-primaryresolves to the oldborder-secondaryvalue rather than the old0.4primary. Every visible chrome color matches the original exactly.Test plan
npm run typecheck(node + workers + viewer)npm test(theme suite + full run pass)npm run lint/npm run format:check🤖 Generated with Claude Code