Add injectable public base path for hosted wrappers#86
Merged
Conversation
a30a304 to
d9de1ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds optional public base-path support so hosted wrappers can mount sideshow under a prefix such as
/u/:accountwhile preserving the core app’s internal route shape.When
basePathis unset, self-hosted behavior is unchanged.What changed
createApp({ basePath }), accepting a string or request-aware hook.window.__SIDESHOW_BASE_PATH__into the viewer./s/:id?part=Nas the html-part iframe endpoint./s/:idwithoutpartredirects toBASE_PATH/?surface=:idso markdown/diff/etc. surfaces open in the full viewer./s/:idbehavior unchanged whenbasePathis unset.Validation
Also validated from the hosted wrapper repo:
npm run typecheck npm test npm run buildThis PR description was generated by Pi using OpenAI GPT-5.1