Skip to content

test(e2e): fix flaky url-routing session-click assertion #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benvinegar merged 1 commit into from
Jun 20, 2026
+8 −3
Merged

test(e2e): fix flaky url-routing session-click assertion #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/url-routing-flaky-fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
9 changes: 6 additions & 3 deletions e2e/url-routing.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,16 @@ test("clicking a session updates the URL to /session/:id", async ({ page, server
await page.goto(server.url);
await expect(page.locator("#sessionList .sess")).toHaveCount(2);

// click the second session row
// click the second session row. Selecting a session pushes /session/:id, then
// focusSurface immediately replaceState's /session/:id/s/:surfaceId once the
// first card is visible — so match the session segment with a boundary, not a
// `$`, or this races the deep-link suffix (see the back/forward test below).
await page.locator(`#sessionList .sess[data-id="${s2.sessionId}"]`).click();
await expect(page).toHaveURL(new RegExp(`/session/${s2.sessionId}$`));
await expect(page).toHaveURL(new RegExp(`/session/${s2.sessionId}(\\b|/)`));

// click the first session row
await page.locator(`#sessionList .sess[data-id="${s1.sessionId}"]`).click();
await expect(page).toHaveURL(new RegExp(`/session/${s1.sessionId}$`));
await expect(page).toHaveURL(new RegExp(`/session/${s1.sessionId}(\\b|/)`));
});

test("navigating to /session/:id selects that session", async ({ page, server }) => {
Expand Down
Loading