Repository navigation
chore(deps): require db-retry 0.7.1 and run the connection-loss tests - #52
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires db-retry 0.7.1, which includes modern-python/db-retry#69:
postgres_retrynow retries aDBAPIErrorthat SQLAlchemy markedconnection_invalidated, which covers asyncpg'sInterfaceError: connection is closed.#51 made the six read use cases own their transaction, and added
tests/use_cases/test_connection_loss.pyas a strictxfailuntil a db-retry release had this fix. This PR raises the floor to>=0.7.1and removes the marker, so the tests now run as ordinary tests.0.6.0 and 0.7.0 are also new to chat-app. Their behaviour changes cover connect-time retries and the multi-host DSN helpers (
is_dsn_multihost,build_connection_factory). chat-app only importsTransactionandpostgres_retry.just testwith db-retry 0.7.1 installed: 129 passed, 100% coverage.ruffandtyare clean.