Repository navigation
docs: the retried coroutine must own its whole transaction - #70
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#69 told readers the retried coroutine must open its own
Transaction. That is narrower than the real rule. A serialization failure or a lost connection ends the whole Postgres transaction, so the retried coroutine must own that transaction from start to finish.Transactionis one way to do that, and a fresh session created inside the coroutine is another.The README now states that rule and the reason for it. On a session another caller began, Postgres has already discarded the earlier statements, and SQLAlchemy's
PendingRollbackErrorstops the retry from committing part of the work.Docs only. The usage example and the API reference line are updated; no code changes.