Repository navigation
chore: upgrade lite-bootstrap to 1.13.0 - #87
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades lite-bootstrap from 1.9.3 to 1.13.0 and folds the two tracing tests into one. This keeps the template in step with modern-python/litestar-sqlalchemy-template#64.
Upgrade
The lock moves only lite-bootstrap. The breaking changes in this range don't touch FastAPI apps: modern-python/lite-bootstrap#279 changes Litestar tracing, and modern-python/lite-bootstrap#270 drops Python 3.10.
pyproject.tomlstays unpinned, sinceopentelemetry_exclude_spansalready works for FastAPI on 1.9.3 (#86).On the upgrade alone the suite passed with one new warning:
Tests
Since modern-python/lite-bootstrap#264, lite-bootstrap warns when
build_app()runs with tracing after aTracerProvideris already installed.test_db_queries_produce_sqlalchemy_spansandtest_request_has_no_asgi_event_spanseach built a traced app, so the second one triggered the warning. They are now one test,test_traced_request_records_server_and_db_spans_only, with the same assertions as the Litestar template: the request records SQLAlchemySELECTspans with parents, and apart from those only the SERVER span. The suite now passes with no warnings.