Repository navigation
Test that a hand pick survives when its issue is unticked - #41
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #40. That PR couldn't test a hand pick in another service that differs from the issue's pick, because
shop/webhad only one tag in its range.The demo's
shop/webgets a1.9.1tag on the footer typo fix, which moves to 12h ago. A new untagged change, "Tidy the footer links", takes its place at the head, so the service still shows one untagged row. SHOP-38 still reaches1.9.0.New smoke test: tick SHOP-38, pick
1.9.1inshop/webby hand (SHOP-38 stays ticked), then clearshop/api. SHOP-38 is unticked,shop/webkeeps1.9.1, and the address reads#shop/web=1.9.1. With thethis.picks[project] === tagguard inapplyIssuesremoved, the test fails.Screenshot: I compared it before and after the change. The only difference is the
shop/webline, which now says "2 of 4 merge requests or commits" instead of "2 of 3". The published screenshot is rebuilt by the Demo workflow on the next release tag.