test(postprocessing): check signed magnitudes in 1-D faceflow cases - #2846
Merged
wpbonelli merged 1 commit intoSep 9, 2026
Merged
Conversation
TameTheGame
marked this pull request as ready for review
September 9, 2026 02:45
wpbonelli
approved these changes
Sep 9, 2026
wpbonelli
left a comment
Member
There was a problem hiding this comment.
reasonable addition, though I admit I'm curious what sequence of events led you to this PR. thanks in any case
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2846 +/- ##
===========================================
+ Coverage 55.5% 73.6% +18.0%
===========================================
Files 644 659 +15
Lines 124135 132282 +8147
===========================================
+ Hits 68947 97402 +28455
+ Misses 55188 34880 -20308 🚀 New features to boost your workflow:
|
Contributor
Author
Just a new open-source contributor looking to start small. Glad it's a worthwhile addition. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing one-dimensional
get_structured_faceflowscases check whether the active-direction array contains nonzero values. Add an independent physical reference: unit conductivity and cell dimensions with prescribed heads 11, 12 and 13 imply face flows[-1, -1, 0]toward increasing column, row or layer number. Check the absent terminal face is exactly zero.This adds ten lines and preserves all seven existing parameterizations, model inputs, simulation calls and dependencies. It is a test improvement; no existing implementation defect is claimed.
Validation on base
18dc192cac9ed731dc84f40bc898e0f4d9f87e20:6.8.0+8680167.dirty.[-1, -1, 0].The full FloPy test suite and project-wide release checks were not run locally. This PR is ready for review and has received maintainer approval on commit
c08bb9d93db82635bd63eb0a063d2042a53710cd. As of September 9, 2026, eleven of twelve main CI test jobs passed, along with build, lint, MODFLOW integration tests and documentation notebook checks. The remaining job, labeled Ubuntu/Python 3.12, failed intest_get_modflow.py::test_python_api[modflow6-MODFLOW-ORG]because the expected executable destination was empty after the download attempt; all seven modified face-flow cases passed in that same job. The download failure appears separate from this assertion change, but its cause remains unconfirmed and CI is not fully green. See the failed job.Related PR #2746 adds broader conversion/round-trip coverage and leaves this existing assertion block unchanged at the head inspected. This patch is limited to the existing physical 1-D cases.
AI assistance: OpenAI Codex using GPT-6 Astra assisted with the assessment, patch and local validation.