Conversation
create/update only read from the JSON body. Adds the query-string merge the docs promise, reusing the same merge_request_params helper as bugs 2065171/2065173. update() now whitelists fields before set_all(), since form-urlencoded cookie-auth requests (which include Bugzilla_api_token) previously failed JSON parsing before reaching it and no longer will.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Component.pm'screate/updateonly read parameters from the JSON POST/PUT body. Adds the query-string merge that the REST docs promise (query string overrides the body on a key collision), reusing the samemerge_request_paramshelper as bugs 2065171/2065173, and fixes a stray-key crash inupdate()'sset_all()call that this change would otherwise expose.Changes
Bugzilla::WebService::Util::merge_request_params(third copy of this helper across open PRs -- will collapse to one once 2065171 or 2065173 merges)Component.pmcreate/update: query string + JSON body merge instead of JSON-body-only; drop the now-unused_get_paramsComponent.pmupdate(): whitelist the 8 documented update fields beforeset_all(), since form-urlencoded cookie-auth requests (which includeBugzilla_api_token) will now actually reach it instead of failing JSON parsing firstqa/t/rest_components.t: cover query-string-only create and query-string-overrides-body updateTest plan
References