[Targeting] Windows launch-on-login

[aminomancer]

Fixes #16432

[aminomancer]

I'm not sure why the tests are complaining about this one, since it's existed for quite some time. The other one is new and just landed in Nightly.

[jaredlockhart]

@aminomancer Oh I see, it's added here:

https://github.com/mozilla-firefox/firefox/blob/3b3f727963c10fe58e6e72c15989ad0e35dbf832/browser/components/asrouter/modules/ASRouterTargeting.sys.mjs#L1181

but not here:

https://github.com/mozilla-firefox/firefox/blob/3b3f727963c10fe58e6e72c15989ad0e35dbf832/toolkit/components/nimbus/lib/TargetingContextRecorder.sys.mjs#L118

which is required to be targetable by Nimbus:

https://experimenter.info/platform-guides/desktop/targeting#adding-new-targeting-options

If you added it to the Nimbus targeting context it'll get picked up on the next sync then this should pass 👍

[aminomancer]

@jaredlockhart Thanks, I've added a patch for this. We'll try to remember that in the future.

Is this required by the Nimbus client to even do the client-side targeting, or is it only required for these tests to pass? I'm looking at the code in RemoteSettingsExperimentLoader, and it seems like it's just directly using ASRouterTargeting for targeting.

This targeting config is intended for an experiment that would target 153.0.1 (the dot release). So I'm wondering whether we need to uplift that patch I linked. It doesn't seem like it, but it would be good to confirm.

If Experimenter only cares what's on Nightly, then we shouldn't need to uplift it. But maybe Experimenter will throw an error if we combine a min version of 153.0.1 with an advanced targeting config that uses attributes that only exist on 155, and then I guess we'd need to uplift the attributes.

[jaredlockhart]

@aminomancer Perfect here it is:

https://github.com/mozilla/experimenter/pull/16470/changes#diff-b1f24c02bf0792a736219641270854bf2706698f595e0599018d0446ece2c7c9

And yes so right now only Experimenter is validating against that list but soon desktop will soon as well so better to get it all in place now rather than getting caught out when the client makes the switch.

After the above lands we can update this and it should be passing 🙏

[jaredlockhart]

@aminomancer Okay all tidied up, I'll mark it as blocked so it doesn't get accidentally merged until you're ready.