Skip to content

Fetch growth estimates from Zacks (fix #99) - #103

Open
kocielnik wants to merge 16 commits into
mrhappyasthma:masterfrom
kocielnik:test-zacks
Open

Fetch growth estimates from Zacks (fix #99)#103
kocielnik wants to merge 16 commits into
mrhappyasthma:masterfrom
kocielnik:test-zacks

Conversation

@kocielnik

@kocielnik kocielnik commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Preview: https://isthisstockgood.vercel.app/

Other changes:

  • Project config is migrated to UV (seems to be the standard now) for easier preview deployments to Vercel.
    • Please let me know if this doesn't help and I'll revert it promptly.
  • The API path now supports other tickers.
    • Some tickers do not have the 5-year estimate. This helps verify their handling by the program.

Comment thread tests/test_DataSources.py
def test_msn_money():
test_ticker = 'MSFT'
test_name = 'Microsoft Corp'
test_name = 'Microsoft Corporation'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data returned from the source changed.

Comment thread pyproject.toml

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vercel said it'll only deploy my preview if the app's config is UV-compatible.

@mrhappyasthma, if this would break your deployments, please let me know and I'll revert👍

@kocielnik kocielnik Aug 15, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had a good experience with UV so far.

For every problem I've had with it, I was able to find the solution (find, not "prompt") much quicker than when I had a similar problem using other tools, even Poetry.

My experience with Python and UV agrees with this:

‒ Which Python package manager should I use?
‒ Use uv. It handles dependency management, virtual environments, Python version management, and package building in a single tool. It follows Python packaging standards, generates cross-platform lockfiles, and resolves dependencies faster than any alternative. For most Python projects in 2026, uv is the right default.

‒ Tim Hopper, https://pydevtools.com/handbook/explanation/which-python-package-manager-should-i-use/

return float(estimate)

for i, line in enumerate(lines):
if "Next Year (" in line:

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The opening bracket is important. Earlier on the page, "Next Year" appears in another context, and there it lacks the parentheses.

@kocielnik kocielnik changed the title Fetch growth estimates from Zacks (fixes #99) Fetch growth estimates from Zacks (fixes mrhappyasthman#99) Aug 5, 2026
@kocielnik kocielnik changed the title Fetch growth estimates from Zacks (fixes mrhappyasthman#99) Fetch growth estimates from Zacks (fixes mrhappyasthma#99) Aug 5, 2026
@kocielnik kocielnik changed the title Fetch growth estimates from Zacks (fixes mrhappyasthma#99) Fetch growth estimates from Zacks (fix #99) Aug 5, 2026
@kocielnik

Copy link
Copy Markdown
Contributor Author

@mrhappyasthma If there's anything else I can do to help fix this issue, please let me know.

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant