Fix voice packet spam and very FPS drop#5066
Open
MoriskaSosiska wants to merge 6 commits into
Open
Conversation
|
I'll keep that in mind, as cheaters have already touched my project. |
|
Thank you for the fix, and we'll be waiting for the review. |
MoriskaSosiska
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello again!
You may choose not to pay attention to my PR, but I'd really appreciate it if you could review it because it fixes a vulnerability in the MTA client.
This fix addresses the FPS drops (up to the point where the client freezes) that occur when cheaters spam voice chat packets, causing nearby players' games to freeze or stutter due to
BASS_StreamPutDataslowing down execution.I moved the
100 mscooldown check from the client, made a few adjustments toCVoiceDataPacket, and added a check for the return value ofspeex_decode_int.I also removed the
reservecall and theCVoiceDataPacketconstructor so that memory is only allocated if the100 msinterval has elapsed.This vulnerability has already been exploited by cheaters on NEXTRP and other projects, as I was told.
Thanks for taking the time to read this!😄