Skip to content

Apply fixes from StyleCI #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
murrant wants to merge 1 commit into
base: fix-query-builder-parser
Choose a base branch
from
Open

Apply fixes from StyleCI #587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion LibreNMS/Alerting/QueryBuilderFluentParser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public function toQuery(): ?Builder
* @param array{condition: string, rules: array<array{field: string, operator: string, value: mixed}>} $rule
* @param string|null $parent_condition AND or OR (for root, this should be null)
*/
protected function parseGroupToQuery(Builder $query, array $rule, string $parent_condition = null): Builder
protected function parseGroupToQuery(Builder $query, array $rule, ?string $parent_condition = null): Builder
{
return $query->where(function ($query) use ($rule): void {
foreach ($rule['rules'] as $group_rule) {
Expand Down