add agents page#2309
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Warning Review limit reached
More reviews will be available in 45 minutes and 40 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a new MDX documentation page for ERC-8004 (AI Agent Discovery) in the ENS Omnigraph API docs, covering the ChangesERC-8004 Omnigraph Documentation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/ensnode.io/src/content/docs/docs/integrate/omnigraph/agents.mdx`:
- Line 65: The identityRegistry value in the agent query example is using a
truncated address format "0x8004…432" which appears runnable but is actually
incomplete, making it easy for users to copy-paste a broken value. Replace this
truncated address with either a complete valid address or an explicit
placeholder token (like <IDENTITY_REGISTRY_ADDRESS> or similar) that clearly
indicates the value needs to be substituted, ensuring users understand they must
provide their own actual value before running the query.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 1036505d-338d-4da2-86c9-5e0807e775f3
📒 Files selected for processing (2)
docs/ensnode.io/config/integrations/starlight/sidebar-topics/integrate.tsdocs/ensnode.io/src/content/docs/docs/integrate/omnigraph/agents.mdx
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/ensnode.io/src/content/docs/docs/integrate/omnigraph/agents.mdx (1)
89-99:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winAlign the search description with the example.
The prose says the query can search by owner, but this snippet only demonstrates chain/name filters. Either add an owner predicate or remove “owner” from the text.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/ensnode.io/src/content/docs/docs/integrate/omnigraph/agents.mdx` around lines 89 - 99, The introductory text in the documentation states that agents can be found by chain, owner, or card name, but the GraphQL example query only demonstrates filtering by chain and name without any owner predicate. Either add an owner filter to the agents query where clause to match the documentation text, or remove the mention of "owner" from the introductory sentence so the description accurately reflects what the example demonstrates.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@docs/ensnode.io/src/content/docs/docs/integrate/omnigraph/agents.mdx`:
- Around line 89-99: The introductory text in the documentation states that
agents can be found by chain, owner, or card name, but the GraphQL example query
only demonstrates filtering by chain and name without any owner predicate.
Either add an owner filter to the agents query where clause to match the
documentation text, or remove the mention of "owner" from the introductory
sentence so the description accurately reflects what the example demonstrates.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: ab9b198a-0f51-4299-80a6-9271a4c12368
📒 Files selected for processing (1)
docs/ensnode.io/src/content/docs/docs/integrate/omnigraph/agents.mdx
| }, | ||
| { | ||
| label: "Complementary protocols", | ||
| collapsed: false, |
There was a problem hiding this comment.
maybe collapse it by default? i fell like too many open topics with color badges. or maybe just remove badge?
There was a problem hiding this comment.
@sevenzing Yes I think best to collapse by default 👍
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@docs/ensnode.io/src/content/docs/docs/integrate/omnigraph/complementary/erc8004.mdx`:
- Line 13: The ERC-8004 explanatory text contains grammatical errors that need
correction. Change "an new" to "a new" in the main paragraph defining ERC-8004.
Additionally, review and fix the other user-facing phrasing errors mentioned in
the comment: "API let" should be corrected to proper phrasing, "enum cover"
needs to be clarified, and "threory" should be corrected to the proper term.
Ensure all these corrections are applied throughout the documentation to
maintain clarity for readers.
- Around line 133-143: The introductory description states that the
FindErc8004Agents query searches by chain, owner, or card name, but the actual
GraphQL query example only includes filters for chainName, cardName, and ensName
with no owner filter. Update the description text before the code block to
accurately reflect the three filter fields that are actually demonstrated in the
query: chainName, cardName, and ensName.
- Line 142: The GraphQL filter key in the ensName field contains a typo where
`constains` is used instead of the correct spelling `contains`. Locate the
ensName filter definition in the example query and correct the spelling of the
key from `constains` to `contains` to match the correct syntax shown elsewhere
in the same query.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 19666714-4d42-4664-89ea-db91baaba82e
📒 Files selected for processing (2)
docs/ensnode.io/config/integrations/starlight/sidebar-topics/integrate.tsdocs/ensnode.io/src/content/docs/docs/integrate/omnigraph/complementary/erc8004.mdx
|
@greptile review |
lightwalker-eth
left a comment
lightwalker-eth
left a comment
There was a problem hiding this comment.
@sevenzing Hey thanks for your updates 👍 Reviewed and shared feedback.
| }, | ||
| { | ||
| label: "Complementary protocols", | ||
| collapsed: false, |
There was a problem hiding this comment.
@sevenzing Yes I think best to collapse by default 👍
| collapsed: false, | ||
| items: [ | ||
| { | ||
| label: "Agents / ERC-8004", |
There was a problem hiding this comment.
| label: "Agents / ERC-8004", | |
| label: "AI Agents / ERC-8004", |
Does that fit, or does it make the value too long for display in the nav bar?
| link: "/docs/integrate/omnigraph/protocol-acceleration", | ||
| }, | ||
| { | ||
| label: "Complementary protocols", |
There was a problem hiding this comment.
| label: "Complementary protocols", | |
| label: "Complementary Protocols", |
Other nav entries are capitalizing each word
| { | ||
| label: "Agents / ERC-8004", | ||
| link: "/docs/integrate/omnigraph/complementary/erc8004", | ||
| badge: { |
There was a problem hiding this comment.
I think best to remove any badge here. The idea that it's coming soon just needs to be on the page itself.
| @@ -0,0 +1,187 @@ | |||
| --- | |||
| title: ERC-8004 (AI Agent Discovery) | |||
There was a problem hiding this comment.
I assume we should rename this page from erc8004.mdx to erc-8004.mdx (add hyphen)
| name { beautified } | ||
| } | ||
| resolve { | ||
| profile { |
There was a problem hiding this comment.
We're missing a key part of the story here. Please see my feedback above on the "Who this feature is for" section.
We aren't building this feature for people who only want to query ERC-8004. There's no point for us to do that. Other APIs for that already exist.
What makes our case special and gives it value is because it COMBINES ENS with ERC-8004.
The example queries here are all ERC-8004 only. This needs to change. Each example query needs to be updated so that it combines ENS with ERC-8004 in a way that feels practical and valuable and demonstrates a real use case.
| Each entry in `attestations` is one ENSIP-25 attestation, with its `verification` status and the indexed ERC-8004 agent nested inline. By default `attestations` returns only `VERIFIED` attestations; pass `where` to include the partial ones. | ||
|
|
||
| ```graphql ins={8-29} | ||
| query AgentsForName { |
There was a problem hiding this comment.
It seems to me it would be more interesting to change this into AgentsForAddress and change the Omnigraph query from being about a domain by name, to being an account by address.
Then, the data requested in the query could include the ENS primary name of that address, the profile of that primary name, and info about any ERC-8004 agents that might be associated with the address.
| resolve { | ||
| profile { | ||
| erc8004agents { | ||
| context |
There was a problem hiding this comment.
This context field seems curious to me. What's the idea here?
| where: { | ||
| chainName: { eq: ETHEREUM } | ||
| cardName: { contains: "trading" } | ||
| ensName: { contains: "eth" } |
There was a problem hiding this comment.
Hmm. What's the big idea here? Suggest to refine it to be more clear
| profile { | ||
| erc8004agents { | ||
| attestations { | ||
| verification |
There was a problem hiding this comment.
Seems no value to include this field in the response then?
Take over the ERC-8004 (AI Agent Discovery) page from #2309 and align both it and the EFP page to Lightwalker's terminology choices: - New nav group "Complementary Protocols" (collapsed), containing "EFP (Social Graph)" and "AI Agents / ERC-8004"; no SOON badge in nav. - ERC-8004 page: title "ERC-8004 (AI Agent Identity, Discovery, and Reputation)", "A complementary protocol for ENS" framing callout, plugin-named `erc8004` field (was `erc8004agents`), nested `agent` (was `erc8004agent`), "Example Queries" H2 with H3 examples, hyphenated filename erc-8004.mdx. Consistent "ENS Omnigraph" naming. - Move EFP page to omnigraph/complementary/efp (redirect added) and add the parallel "complementary to ENS" framing callout; sidebar label "EFP (Social Graph)". - Update inbound links (ensnode-plugins, database-schemas, example aside).
|
Superseded by #2327, which brings this ERC-8004 page into a new "Complementary Protocols" group (alongside the EFP page) and applies the terminology choices from your review — |
3 participants
Lite PR
Tip: Review docs on the ENSNode PR process
Summary
This PR adds a
/omnigraph/agentspage with description of how Omnigraph will be connected to ERC-8004 adn ENSIP-25Pre-Review Checklist (Blocking)