-
Notifications
You must be signed in to change notification settings - Fork 5
fix: extension-type metadata dropped for list-backed logical types (ITL-627) #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
brian-arnold
merged 13 commits into
main
from
eywalker/itl-627-extension-type-metadata-dropped-for-list-backed-logical
Aug 26, 2026
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
8fd3252
docs(specs): add ITL-627 design spec for list-backed extension type f…
kurodo3[bot] 08b50d9
docs(specs): expand ITL-627 spec scope and add implementation plan
kurodo3[bot] 3b9071d
fix(logical_types): pass metadata to make_polars_extension_type in Li…
kurodo3[bot] 21676b8
test(operators): add regression tests for list extension column round…
kurodo3[bot] 8791c06
test(operators): add data integrity assertions and clean up registrat…
kurodo3[bot] ef49aea
test(operators): fix any->all in path value assertions
kurodo3[bot] 450c65c
fix(hashing): hash list-backed extension columns element-by-element
kurodo3[bot] 1628db2
refactor(hashing): move method-body imports to module level; improve …
kurodo3[bot] 601ace5
fix(operators): MergeJoin produces extension-typed list when merging …
kurodo3[bot] 6d545f5
refactor(operators): rename list_lt -> list_logical_type; add comment…
kurodo3[bot] d0a9044
fix(tests): use type-converter cache for list[Path] extension type in…
kurodo3[bot] 8a9f4a3
Merge branch 'main' into eywalker/itl-627-extension-type-metadata-dro…
eywalker fb2b062
fix(hashing): address four review issues from brian-arnold
kurodo3[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The outer wrapper's extension identity is dropped on this branch. The scalar path below (L281-289) deliberately folds
extension_type.extension_nameinto the hash token, but this branch returns a barelarge_list(large_binary)with no record of which wrapper produced it.Verified: single-row
extension<list[orcapod.file]>andextension<set[orcapod.file]>tables holding the same file both hash to0000019c292aa9a0on this branch; onmainthey differ (000001ea...vs000001df...). Two structurally distinct logical types are now indistinguishable tohash_table, so a memoized record keyed on one can be served for the other.This is a silent-wrong-result bug rather than a crash, and the fix is small (include
extension_type.extension_namein the result the way the scalar path does). Worth doing before merge, since fixing it later is another cache-invalidating hash change.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. The result now includes the outer extension name the same way the scalar path does.
The list-backed path now returns
(pa.large_binary(), combined_bytes)wherecombined_bytes = type_name.encode() + b"::" + b"\x00".join(element_hashes)andtype_name = extension_type.extension_name.replace(".", ":"). Forextension<list[orcapod.file]>this producesb"list[orcapod:file]::<h0>\x00<h1>". Forextension<set[orcapod.file]>with the same files it producesb"set[orcapod:file]::<h0>\x00<h1>"— distinct because the outer wrapper name differs.Added
test_list_and_set_file_extension_produce_distinct_hashesto directly assert the two hashes differ.