Skip to content

fix vm virtualization detection#19

Merged
ncode merged 1 commit into
mainfrom
juliano/extra-releases
Jun 21, 2026
Merged

fix vm virtualization detection#19
ncode merged 1 commit into
mainfrom
juliano/extra-releases

Conversation

@ncode

@ncode ncode commented Jun 20, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes native VM content validation failures where supported lab guests reported virtual: "physical" and is_virtual: false despite QEMU/KVM indicators being present.

Changes

  • Detect QEMU/KVM from DMI/SMBIOS/PCI indicators on OpenBSD, NetBSD, DragonFly BSD, and illumos.
  • Detect Windows QEMU/KVM guests from WMI manufacturer/model/BIOS indicators.
  • Make the Windows release gate compatible with Windows PowerShell 5.1.
  • Add OpenSpec coverage and update the changelog.

Root Cause

The existing virtualization detector only handled Linux, macOS, FreeBSD, OpenBSD's narrow product map, and Windows' older OEM/netkvm patterns. NetBSD, DragonFly, and illumos fell through to physical; OpenBSD and Windows missed the QEMU/SeaBIOS values exposed by the lab VMs.

Validation

  • Focused virtualization tests pass.
  • Native lab content checks now report virtual: "kvm" and is_virtual: true on OpenBSD, NetBSD, DragonFly BSD, illumos/OmniOS, and Windows.
  • Affected release gates pass.
  • Full JSON parse passes on affected guests.
  • 17 release targets cross-compile.
  • go test ./...: 1455 passed.
  • go vet ./...: no issues.
  • openspec validate fix-vm-virtualization-detection --strict: valid.
  • git diff --check: clean.

@ncode ncode changed the title [codex] fix vm virtualization detection fix vm virtualization detection Jun 20, 2026
@ncode ncode marked this pull request as ready for review June 20, 2026 16:42
@ncode ncode force-pushed the juliano/extra-releases branch from 2e3e175 to f04b83e Compare June 20, 2026 17:49
@ncode ncode force-pushed the juliano/extra-releases branch from f04b83e to 47ecf77 Compare June 20, 2026 17:59
@ncode ncode merged commit d9bafb8 into main Jun 21, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant