fix vm virtualization detection#19
Merged
Merged
Conversation
2e3e175 to
f04b83e
Compare
f04b83e to
47ecf77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes native VM content validation failures where supported lab guests reported
virtual: "physical"andis_virtual: falsedespite QEMU/KVM indicators being present.Changes
Root Cause
The existing virtualization detector only handled Linux, macOS, FreeBSD, OpenBSD's narrow product map, and Windows' older OEM/netkvm patterns. NetBSD, DragonFly, and illumos fell through to
physical; OpenBSD and Windows missed the QEMU/SeaBIOS values exposed by the lab VMs.Validation
virtual: "kvm"andis_virtual: trueon OpenBSD, NetBSD, DragonFly BSD, illumos/OmniOS, and Windows.go test ./...: 1455 passed.go vet ./...: no issues.openspec validate fix-vm-virtualization-detection --strict: valid.git diff --check: clean.