Conversation
Problem: No way for caller to skip the default dir search, which makes it awkward to check if the found result was part of the caller's specified `cmds` or a "default" location. Solution: - Skip searching default locations if `cmds` is given. Callers are expected to call `findNvim()` a 2nd time if they want to also search default locations. - Throw an error if both `cmds` and `dirs` are given.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
No way for caller to skip the default dir search, which makes it awkward
to check if the found result was part of the caller's specified
cmdsor a "default" location.
Solution:
cmdsis given. Callers areexpected to call
findNvim()a 2nd time if they want to also searchdefault locations.
cmdsanddirsare given.followup to #432