Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Reviewed by Codex gpt-6-luna (xhigh); verified and validated by Claude Thermo-nuclear review of PR #675 against the bifrost-parity spec (0.65.0). All five behavior points are covered by co-located tests. No frontend, locale, a11y or bridge changes needed. Findings (1):
|
|
Fixes landed at the head of this branch (1 of 1 finding fixed, none left). Commands run: |
Adversarial validation (lane-A) at 778c891 — CI diagnosis + re-mergeCI failure root cause: the failing CircleCI run (
Refresh applied: merged the current #620 head ( Re-run requested: hosted CI should re-trigger on this push; the failure is expected to clear. Fast-forward pushed |
Summary
Aligns the Bifrost provider (added in #619) with the tagged upstream v0.65.0
bifrost.tswhere the local port differed:virtual_key_name(omitted when empty or blank); organization is the first root budget'ssource_name; login method stays "API".-vN:Nrevision and trailingYYYYMMDD/YYYY-MM-DDdate; the provider is prefixed only when the visible rows mix providers; two visible rows with the same short name show the raw name. Token counts use K/M/B thresholds (1000 / 999500 / 999500000), one decimal below 10, exact ties rounding up as upstream'stoFixeddoes.bifrost-budget-<budget id>ids (was a description-derived id).current_usageis a known zero.Also moved the module tests to a sibling
tests.rs(the module was already over 1000 lines; it is now 882) and put the label helpers inmodel_labels.rs.Upstream reference
ed654746c,7d8ccddad), v0.65.0.bifrost.tsat v0.65.0 (modelName,tokenCount,identity,usageKnown, window ids).Ported / Deferred
Ported: gaps (a) through (e) from the 0.65.0 audit for #619.
Deferred: none. Upstream's 429
Retry-Afterhandling is a separate, known divergence not in this PR.Validation
All run on Rust 1.98.0, E-core wrapper, slot-6 target dir:
cargo +1.98.0 fmt --all: cleancargo +1.98.0 clippy --workspace --all-targets -- -D warnings: passcargo +1.98.0 test -p codexbar bifrost -- --test-threads=4: 21 passed, 0 failed (11 new: identity, blank identity, reset-only unknown window, root extra ids, missing current_usage, model normalization + token counts, mixed-provider prefix, collision fallback, five-row cap, plusmodel_labelsunit tests)No shared code, Tauri crate or frontend changed, so the full
codexbarsuite and vitest were not run.Affected areas
UI proof
Not applicable. No UI code changed; only the strings and identity data the existing Bifrost card renders.