Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the 0.60.4-0.69.0 port gap audit.
Summary
OpenRouter now reports why an optional request degraded and shows an Activity summary, matching upstream v0.61.0:
/credits,/keyand Activity each get a 4 s deadline (was 30 s credits, 1 s key and Activity).Request timed out,Request failed,Request returned HTTP <n>,Response was invalid,Management API key requiredfor an Activity 403,Management API key not configured). The reason was previously only logged at debug level; it now appears in the provider detail rows and the CLI text output.Credits balance: Unavailable right nowwith the reason), API key limit (with "Spending cap, not balance"), API key remaining / used, Reset window (orNo limit configured, orUnavailable right nowwith the reason), Activity tokens / requests / models for the last 30 completed UTC days (orSpend history (last 30 days): Unavailable right nowwith the reason).Rows use the existing
ProviderDisplayDetailpath (menu card, provider detail pane, CLI), so no bridge or frontend change was needed.Upstream reference
aca09cf2f) and "distinguish invalid responses from request failures" (fix(openrouter): distinguish invalid responses from request failures steipete/CodexBar#3733,6cd74d02e).Sources/CodexBarCore/Resources/Plugins/openrouter.js(requestDegradationReason,activityDetails,detailssections,optionalRequestTimeoutSeconds = 4),docs/openrouter.md.Ported / Deferred
Ported: items above.
Deferred:
costUsage.entries). They only feed upstream's Usage & Spend model breakdown; Win-CodexBar'sCostSnapshothas no per-model shape, so this needs a separate spend-catalog change.Activity tokens) becauseProviderDisplayDetailhas no section grouping. Titles are English strings like other providers' detail rows; no locale keys were added.Validation
All with
cargo +1.98.0, slot-5 target dir, E-core wrappers:cargo fmt --all: cleancargo clippy --workspace --all-targets -- -D warnings: passcargo test -p codexbar openrouter: 38 passed, 0 failed (new: detail rows for success, uncapped key and degraded sources; HTTP status and auth typing; timeout vs other transport failure against a stalled local listener; Activity summary counts, dedupe, model counting, safe-integer aggregate overflow)cargo test -p codexbar(full): 2169 passed, 0 failed, 1 ignoredpnpm testnot run.Affected areas
UI proof
Pending: coordinator will capture CUA proof on a fresh build.