Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
UI proof (browser-use)Result: PASS on build
At the maintainer's direction, this proof drove the app's WebView2 over CDP with the browser-use CLI instead of CUA. It used no keyboard, mouse or focus. Clicks were DOM Setup
Results
Unit tests that cover the native tray path:
Validation at
|
| Command | Result |
|---|---|
pnpm install --frozen-lockfile |
pass |
pnpm run check-locale |
873 keys match between Rust and TS |
pnpm test |
65 files, 394 tests passed |
pnpm run lint |
0 errors |
pnpm run build |
pass |
cargo +1.98.0 fmt --all --check |
pass |
cargo +1.98.0 clippy --workspace --all-targets -- -D warnings |
pass |
cargo +1.98.0 test -p codexbar |
2162 passed, 0 failed, 1 ignored |
cargo +1.98.0 test -p codexbar-desktop-tauri -- --skip bootstrap_payload_exposes_every_provider_variant |
461 passed, 0 failed. The skipped test is the non-hermetic #684 test that #711 fixes. |
ci/circleci: pr-check |
success |
Screenshots
All paths are under C:\Users\FSOS\AppData\Local\Win-CodexBar\port-audit\proof\716\shots\.
| File | What it shows |
|---|---|
716-menubar-pace-off.png |
Settings > Menu Bar, dark: the new toggle, unchecked by default, after "Show percent in tray". |
716-menubar-pace-on.png |
The same tab after the on, off, on clicks: the toggle is checked. |
716-menubar-pace-after-relaunch.png |
After a restart of the kit exe: the toggle is still checked. |
Not blocking
- An empty
global_shortcutlogsWARN codexbar_desktop_tauri::shortcut_bridge: Could not parse global shortcut:at every launch. This was already reported on Fix reset refresh timer for resets over 24.8 days away #720 and is onmain; this PR doesn't cause it.
Summary
Re-lands the upstream v0.59 tray pace-color port #493. It was merged on 2026-09-13 only into the stacked base
port/upstream-0.59.0(merge3f08d66c) and never reachedmain;git cherryagainstmain@7695471bstill reported both commits as missing.menuBarColorPacetoggle, "Color tray usage by pace" (off by default, persisted insettings.json).commands/bridge/pace.rs::stage_str(slightly_behind/behind/far_behindandslightly_ahead/ahead/far_ahead), so the tray and the cards read the same stage.Both original commits are cherry-picked with
-x.mainremoved the PopOut surface in #712, so the PopOut test hunk was dropped instead of re-addingPopOutPanel.test.tsx, and the Display tab test keepsmain's Overview layout and always-on-top tests next to the new pace-color test. A third commit adds the two new strings to the seven non-English locale files.Upstream reference
fe7a45ffab530e6b850800fd4a01ef1972709b0d(v0.59, optional pace colors in the menu bar icon).v0.70.0(tag-pinned GET):Sources/CodexBar/PreferencesMenuBarPane.swiftkeeps themenuBarColorPacetoggle "Color Pace Indicator" ("Green pace indicator when behind pace, red when ahead of pace (risk of running out early)").Ported / Deferred
session_pace,weekly_pace,auto_pace) and the icon-and-percent-only disable ruleLocale:
ColorPaceInTrayandColorPaceInTrayHelperare inrust/src/locale.rs,keys.tsand all eight.ftlfiles.Validation
Run in the worker worktree on Rust 1.98.0 and Node 24 at
8c16d5d4:cargo +1.98.0 fmt --all --checkcargo +1.98.0 clippy --workspace --all-targets -- -D warningscargo +1.98.0 test -p codexbarcargo +1.98.0 test -p codexbar-desktop-tauri -- --skip bootstrap_payload_exposes_every_provider_variantpnpm install --frozen-lockfilepnpm run check-localepnpm testpnpm run lintmainpnpm run buildThe skipped desktop test is the non-hermetic #684 test, which reads the real
%APPDATA%\CodexBar\settings.jsononmain. #711 fixes it separately.New tests:
tray_pace_color_is_opt_in_and_follows_canonical_stage(tray_bridge.rs),pace_color_maps_canonical_stage_and_tints_bars(rust/src/tray/render.rs), the settings round-trip inrust/src/settings/tests.rs, and "updates the tray pace color preference" inDisplayTab.test.tsx.Affected areas
rust/src/tray/render.rs,rust/src/tray/mod.rs(TrayPaceColor,render_*_icon_rgba_with_pace)rust/src/settings.rs,rust/src/settings/raw.rs,rust/src/settings/tests.rs(menu_bar_color_pace)apps/desktop-tauri/src-tauri/src/tray_bridge.rs,commands/bridge.rs,commands/settings.rsapps/desktop-tauri/src/surfaces/settings/tabs/DisplayTab.tsxand its test,types/bridge.ts, test fixturesapps/desktop-tauri/src/i18n/keys.ts,rust/src/locale.rs,rust/src/locale/*.ftlUI proof
Pending: a browser-use proof over WebView2 CDP of the Settings > Menu Bar toggle (off by default, persists after toggling), built from this head with isolated data. It will be posted as a "UI proof (browser-use)" comment. The tray icon pixels are native and are covered by the renderer and tray bridge unit tests above.