[NAE-2453] System processes translations#465
Conversation
- add todo place holders for missing translations
- add translations
WalkthroughThe XML process definitions now use named i18n keys for UI titles, labels, placeholders, fields, and messages, with added Slovak and German translations across dashboard, menu, organization-group, and process configurations. ChangesLocalized UI metadata
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
src/main/resources/petriNets/engine-processes/org_group.xml (1)
93-93: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winTypo in English default text: "e-meail" should be "e-mail".
📝 Proposed fix
- <desc name="invite_by_mail_desc">Add e-meail address to send invitation</desc> + <desc name="invite_by_mail_desc">Add e-mail address to send invitation</desc>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/resources/petriNets/engine-processes/org_group.xml` at line 93, Correct the typo in the default description identified by the invite_by_mail_desc element, changing “e-meail” to “e-mail”.src/main/resources/petriNets/engine-processes/process.xml (1)
892-892: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
t6_finishtitle is missing i18n binding.All other finish titles (
deploy_finish,t10_finish,t11_finish,view_finish) havename="..."attributes and corresponding sk/de i18n entries, butt6_finishat line 892 uses a plain<title>Delete</title>with no name and no i18n entries. This is inconsistent with the PR's objective of adding missing translations.🔧 Proposed fix: add name attribute and i18n entries
- <title>Delete</title> + <title name="t6_finish">Delete</title>And add corresponding i18n entries in both locale blocks:
<i18nString name="t6_label">Odstrániť</i18nString> + <i18nString name="t6_finish">Odstrániť</i18nString> <i18nString name="t9_label">Archivovať</i18nString><i18nString name="t6_label">Löschen</i18nString> + <i18nString name="t6_finish">Löschen</i18nString> <i18nString name="t9_label">Archivieren</i18nString>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/resources/petriNets/engine-processes/process.xml` at line 892, Add an i18n binding to the t6_finish title by assigning it a unique name attribute consistent with the other finish titles, then add matching translations for that key in both the sk and de locale blocks.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/main/resources/petriNets/engine-processes/org_group.xml`:
- Around line 23-24: Swap the i18n name attributes for the group_id elements to
match the group_name pattern: use group_id_placeh for the placeholder and
group_id_desc for the description. Also swap the corresponding German
translation entries so group_id_placeh contains “Gruppen-ID eingeben” and
group_id_desc contains “ID der Organisationsgruppe”.
---
Outside diff comments:
In `@src/main/resources/petriNets/engine-processes/org_group.xml`:
- Line 93: Correct the typo in the default description identified by the
invite_by_mail_desc element, changing “e-meail” to “e-mail”.
In `@src/main/resources/petriNets/engine-processes/process.xml`:
- Line 892: Add an i18n binding to the t6_finish title by assigning it a unique
name attribute consistent with the other finish titles, then add matching
translations for that key in both the sk and de locale blocks.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 3fd0bb57-2906-4fe6-a8e8-d85418720be9
📒 Files selected for processing (9)
src/main/resources/petriNets/engine-processes/dashboard_item.xmlsrc/main/resources/petriNets/engine-processes/dashboard_management.xmlsrc/main/resources/petriNets/engine-processes/menu/case_view_configuration.xmlsrc/main/resources/petriNets/engine-processes/menu/menu_item.xmlsrc/main/resources/petriNets/engine-processes/menu/single_task_view_configuration.xmlsrc/main/resources/petriNets/engine-processes/menu/tabbed_ticket_view_configuration.xmlsrc/main/resources/petriNets/engine-processes/menu/task_view_configuration.xmlsrc/main/resources/petriNets/engine-processes/org_group.xmlsrc/main/resources/petriNets/engine-processes/process.xml
- swap tag names
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/main/resources/petriNets/engine-processes/org_group.xml (1)
306-307: 🎯 Functional Correctness | 🔴 Critical | ⚡ Quick winGerman translations for
group_id_descandgroup_id_placehare still swapped.The previous review identified this issue and the data field name attributes (lines 23–24) were correctly fixed, but the German i18n values were not swapped to match. Currently:
group_id_desc= "Gruppen-ID eingeben" (this is placeholder prompt text, not a description)group_id_placeh= "ID der Organisationsgruppe" (this is a description, not a placeholder prompt)The Slovak entries (lines 259–260) are correct, confirming the intended mapping. German users will see the wrong text in both the placeholder and description fields.
🔧 Fix: swap the German values to match the corrected key names
- <i18nString name="group_id_desc">Gruppen-ID eingeben</i18nString> - <i18nString name="group_id_placeh">ID der Organisationsgruppe</i18nString> + <i18nString name="group_id_desc">ID der Organisationsgruppe</i18nString> + <i18nString name="group_id_placeh">Gruppen-ID eingeben</i18nString>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/resources/petriNets/engine-processes/org_group.xml` around lines 306 - 307, Swap the German i18n values for group_id_desc and group_id_placeh in the relevant resource: group_id_desc must use “ID der Organisationsgruppe”, while group_id_placeh must use “Gruppen-ID eingeben”, matching the corrected field-name mapping and Slovak entries.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/main/resources/petriNets/engine-processes/org_group.xml`:
- Around line 306-307: Swap the German i18n values for group_id_desc and
group_id_placeh in the relevant resource: group_id_desc must use “ID der
Organisationsgruppe”, while group_id_placeh must use “Gruppen-ID eingeben”,
matching the corrected field-name mapping and Slovak entries.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 40a59a9b-6445-4501-b8d3-72b71ebc3234
📒 Files selected for processing (1)
src/main/resources/petriNets/engine-processes/org_group.xml
1 participant
Description
Add missing translations to system processes
Implements NAE-2453
Dependencies
No new dependencies were introduced
Third party dependencies
No new dependencies were introduced
Blocking Pull requests
There are no dependencies on other PR
How Has Been This Tested?
Manually
Test Configuration
Checklist:
Summary by CodeRabbit