Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,9 @@ import {
SimpleFilter,
AbstractTabbedCaseViewComponent,
ViewIdService, NAE_DEFAULT_HEADERS,
NAE_BASE_FILTER, AllowedNetsServiceFactory, AllowedNetsService, OverflowService
NAE_BASE_FILTER, AllowedNetsServiceFactory, AllowedNetsService, OverflowService, Case
} from '@netgrif/components-core';
import {HeaderComponent} from '@netgrif/components';
import {Case} from "../../../../../../netgrif-components-core/src/lib/resources/interface/case";
import {TranslateService} from "@ngx-translate/core";

const baseFilterFactory = (injectedData: InjectedTabbedCaseViewData) => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {ChangeDetectionStrategy, Component, OnInit} from '@angular/core';
import {Component, OnInit} from '@angular/core';
import {NAE_TASK_FORCE_OPEN, NAE_VIEW_ID_SEGMENT, TabContent, ViewIdService} from '@netgrif/components-core';
import {BuilderTabbedCaseViewComponent} from './builder-tabbed-case-view/builder-tabbed-case-view.component';
import {
Expand All @@ -14,8 +14,7 @@ import {TranslateService} from "@ngx-translate/core";
{provide: NAE_VIEW_ID_SEGMENT, useValue: 'all-cases'},
{provide: NAE_TASK_FORCE_OPEN, useValue: false},
ViewIdService
],
changeDetection: ChangeDetectionStrategy.OnPush
]
})
export class BuilderTabsExampleComponent implements OnInit {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {MatDialog} from '@angular/material/dialog';
import {ActivatedRoute, Router} from '@angular/router';
import {ImportService} from '@netgrif/petriflow';
import {of} from 'rxjs';
import {BuilderModeService} from './builder-mode.service';
import {BuilderModeService} from './services/builder-mode.service';
import {ArcFactory} from './modeler/edit-mode/domain/arc-builders/arc-factory.service';
import {EditModeService} from './modeler/edit-mode/edit-mode.service';
import {ExportService} from '@netgrif/petriflow';
Expand Down
10 changes: 6 additions & 4 deletions projects/netgrif-components/src/lib/builder/builder.component.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {Component, Inject, Optional} from '@angular/core';
import {BuilderMode, BuilderModeService} from "./builder-mode.service";
import {ChangeDetectionStrategy, Component, Inject, Optional} from '@angular/core';

Check warning on line 1 in projects/netgrif-components/src/lib/builder/builder.component.ts

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Remove this unused import of 'ChangeDetectionStrategy'.

See more on https://sonarcloud.io/project/issues?id=netgrif_components&issues=AZ875Dk0kaR5yoRYc0fg&open=AZ875Dk0kaR5yoRYc0fg&pullRequest=341
import {BuilderMode, BuilderModeService} from "./services/builder-mode.service";
import {ModelService} from "./modeler/services/model/model.service";
import {ActivatedRoute, Router} from "@angular/router";
import {MatDialog} from "@angular/material/dialog";
Expand Down Expand Up @@ -52,8 +52,9 @@
import {BuilderPaginatorIntl} from './modeler/components/master-detail/main-master/builder-paginator-inpl';
import {MAT_FORM_FIELD_DEFAULT_OPTIONS} from '@angular/material/form-field';
import {I18nControlService} from './modeler/i18n-mode/i18n-control.service';
import {BuilderIntegrationService} from "./builder-integration.service";
import {BuilderIntegrationService} from "./services/builder-integration.service";
import {TaskModeService} from "./modeler/task-mode/task-mode.service";
import {LocalStorageService} from "./services/local-storage.service";

@Component({
selector: 'nc-builder',
Expand Down Expand Up @@ -108,7 +109,8 @@
BuilderModeService,
I18nControlService,
BuilderIntegrationService,
TaskModeService
TaskModeService,
LocalStorageService
]
})
export class BuilderComponent {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import {HistoryService} from '../../modeler/services/history/history.service';
import {ModelService} from '../../modeler/services/model/model.service';
import {CanvasToolContext} from "../../modeler/edit-mode/services/modes/canvas-tool-context";
import {LocalStorageService} from "../../services/local-storage.service";

export enum RoleRefType {
TRANSITION = 'transition',
Expand All @@ -25,6 +26,7 @@
processUserRefs?: Array<ProcessPermissionRef>;
modelService: ModelService;
historyService: HistoryService;
localStorageService: LocalStorageService;
}

@Component({
Expand All @@ -50,12 +52,14 @@

private modelService: ModelService;
private historyService: HistoryService;
private _localStorageService: LocalStorageService;

Check warning on line 55 in projects/netgrif-components/src/lib/builder/dialogs/dialog-manage-roles/dialog-manage-roles.component.ts

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Member '_localStorageService' is never reassigned; mark it as `readonly`.

See more on https://sonarcloud.io/project/issues?id=netgrif_components&issues=AZ9uiMusaPy58e_is5WS&open=AZ9uiMusaPy58e_is5WS&pullRequest=341

constructor(
@Inject(MAT_DIALOG_DATA) public data: ManagePermissionData,
@Inject(MAT_DIALOG_DATA) public data: ManagePermissionData
) {
this.modelService = data.modelService;
this.historyService = data.historyService;
this._localStorageService = data.localStorageService;
if (this.data.type === RoleRefType.TRANSITION) {
const arrayRoleRefs = [...this.data.rolesRefs];
this.addDefaultRoleRefs(arrayRoleRefs);
Expand Down Expand Up @@ -127,12 +131,12 @@
this.dataSource.sort = this.sort;
this.usersDataSource.sort = this.userSort;
this.sort.sort(({
id: localStorage.getItem(ModelerConfig.LOCALSTORAGE.PERMISSION_DIALOG.ROLE_SORT),
start: localStorage.getItem(ModelerConfig.LOCALSTORAGE.PERMISSION_DIALOG.ROLE_DIRECTION)
id: this._localStorageService.getItem(ModelerConfig.LOCALSTORAGE.PERMISSION_DIALOG.ROLE_SORT),
start: this._localStorageService.getItem(ModelerConfig.LOCALSTORAGE.PERMISSION_DIALOG.ROLE_DIRECTION)
}) as MatSortable);
this.userSort.sort(({
id: localStorage.getItem(ModelerConfig.LOCALSTORAGE.PERMISSION_DIALOG.USER_REF_SORT),
start: localStorage.getItem(ModelerConfig.LOCALSTORAGE.PERMISSION_DIALOG.USER_REF_DIRECTION)
id: this._localStorageService.getItem(ModelerConfig.LOCALSTORAGE.PERMISSION_DIALOG.USER_REF_SORT),
start: this._localStorageService.getItem(ModelerConfig.LOCALSTORAGE.PERMISSION_DIALOG.USER_REF_DIRECTION)
}) as MatSortable);
}

Expand Down Expand Up @@ -250,13 +254,13 @@
}

sortRoleRefs(sort: Sort): void {
localStorage.setItem(ModelerConfig.LOCALSTORAGE.PERMISSION_DIALOG.ROLE_SORT, sort.active);
localStorage.setItem(ModelerConfig.LOCALSTORAGE.PERMISSION_DIALOG.ROLE_DIRECTION, sort.direction);
this._localStorageService.setItem(ModelerConfig.LOCALSTORAGE.PERMISSION_DIALOG.ROLE_SORT, sort.active);
this._localStorageService.setItem(ModelerConfig.LOCALSTORAGE.PERMISSION_DIALOG.ROLE_DIRECTION, sort.direction);
}

sortUserRefs(sort: Sort): void {
localStorage.setItem(ModelerConfig.LOCALSTORAGE.PERMISSION_DIALOG.USER_REF_SORT, sort.active);
localStorage.setItem(ModelerConfig.LOCALSTORAGE.PERMISSION_DIALOG.USER_REF_DIRECTION, sort.direction);
this._localStorageService.setItem(ModelerConfig.LOCALSTORAGE.PERMISSION_DIALOG.USER_REF_SORT, sort.active);
this._localStorageService.setItem(ModelerConfig.LOCALSTORAGE.PERMISSION_DIALOG.USER_REF_DIRECTION, sort.direction);
}

ngOnDestroy(): void {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,10 @@
import {ModelChange} from '../../modeler/history-mode/model/model/model-change';
import {ModelService} from '../../modeler/services/model/model.service';
import {DialogManageRolesComponent, RoleRefType} from '../dialog-manage-roles/dialog-manage-roles.component';
import {BuilderModeService, BuilderMode} from "../../builder-mode.service";
import {BuilderModeService, BuilderMode} from "../../services/builder-mode.service";
import {HistoryService} from "../../modeler/services/history/history.service";
import {CanvasToolContext} from "../../modeler/edit-mode/services/modes/canvas-tool-context";
import {LocalStorageService} from '../../services/local-storage.service';

export interface ModelEditData {
model: ModelChange;
Expand All @@ -36,6 +37,7 @@
private _processTool: ProcessActionsTool;
private _builderModeService: BuilderModeService;
private historyService: HistoryService;
private _localStorageService: LocalStorageService;

Check warning on line 40 in projects/netgrif-components/src/lib/builder/dialogs/dialog-model-edit/dialog-model-edit.component.ts

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Member '_localStorageService' is never reassigned; mark it as `readonly`.

See more on https://sonarcloud.io/project/issues?id=netgrif_components&issues=AZ9uiMxwaPy58e_is5WU&open=AZ9uiMxwaPy58e_is5WU&pullRequest=341

constructor(
@Inject(MAT_DIALOG_DATA) public data: ModelEditData,
Expand All @@ -47,6 +49,7 @@
this._processTool = data.context.processTool;
this._builderModeService = data.context.builderModeService;
this.historyService = data.context.editModeService.historyService;
this._localStorageService = data.context.localStorageService;

this.idCtrl = new FormControl('', [Validators.required]);
this.versionCtrl = new FormControl('', [
Expand All @@ -68,7 +71,8 @@
processUserRefs: this.modelService.model.getUserRefs(),
userLists: this.modelService.model.getDataSet().filter(item => item.type === DataType.USER_LIST),
modelService: this.modelService,
historyService: this.historyService
historyService: this.historyService,
localStorageService: this._localStorageService
}
});
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,10 @@
import {ModelService} from '../../modeler/services/model/model.service';
import {DialogManageRolesComponent, RoleRefType} from '../dialog-manage-roles/dialog-manage-roles.component';
import {ChangedTransition} from './changed-transition';
import {BuilderModeService, BuilderMode} from '../../builder-mode.service';
import {BuilderModeService, BuilderMode} from '../../services/builder-mode.service';
import {HistoryService} from "../../modeler/services/history/history.service";
import {CanvasToolContext} from "../../modeler/edit-mode/services/modes/canvas-tool-context";
import {LocalStorageService} from '../../services/local-storage.service';

export interface TransitionEditData {
transitionId: string;
Expand All @@ -37,6 +38,7 @@
private _actionsMasterDetail: ActionsMasterDetailService;
private _builderModeService: BuilderModeService;
private _historyService: HistoryService;
private _localStorageService: LocalStorageService;

Check warning on line 41 in projects/netgrif-components/src/lib/builder/dialogs/dialog-transition-edit/dialog-transition-edit.component.ts

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Member '_localStorageService' is never reassigned; mark it as `readonly`.

See more on https://sonarcloud.io/project/issues?id=netgrif_components&issues=AZ9uiMxjaPy58e_is5WT&open=AZ9uiMxjaPy58e_is5WT&pullRequest=341

constructor(
@Inject(MAT_DIALOG_DATA) public data: TransitionEditData,
Expand All @@ -49,6 +51,7 @@
this._actionsMasterDetail = data.context.actionsMasterDetail;
this._builderModeService = data.context.builderModeService;
this._historyService = data.context.editModeService.historyService;
this._localStorageService = data.context.localStorageService;

this.transition = new ChangedTransition(undefined, this._modelService.model.getTransition(data.transitionId).clone());
this.form = new FormControl('', [
Expand Down Expand Up @@ -96,7 +99,8 @@
userRefs: this.transition.transition.userRefs,
userLists: this._modelService.model.getDataSet().filter(item => item.type === DataType.USER_LIST),
modelService: this._modelService,
historyService: this._historyService
historyService: this._historyService,
localStorageService: this._localStorageService
}
});
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {NO_ERRORS_SCHEMA} from '@angular/core';
import {TestBed} from '@angular/core/testing';
import {MatDialog} from '@angular/material/dialog';
import {Router} from '@angular/router';
import {BuilderModeService} from '../../builder-mode.service';
import {BuilderModeService} from '../../services/builder-mode.service';
import {ArcFactory} from '../../modeler/edit-mode/domain/arc-builders/arc-factory.service';
import {ModelService} from '../../modeler/services/model/model.service';
import {SelectedTransitionService} from '../../modeler/selected-transition.service';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import {ModelService} from '../../modeler/services/model/model.service';
import {DataFieldUtils} from '../data-field-utils';
import {ComponentDef, DataRefDef, FieldListService, PropertyDef} from '../field-list/field-list.service';
import {GridsterService} from '../gridster/gridster.service';
import {BuilderModeService, BuilderMode} from "../../builder-mode.service";
import {BuilderModeService, BuilderMode} from "../../services/builder-mode.service";

@Component({
selector: 'nc-builder-edit-panel',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {MatDialog} from '@angular/material/dialog';
import {MatSnackBar} from '@angular/material/snack-bar';
import {Router} from '@angular/router';
import {PetriNet} from '@netgrif/petriflow';
import {BuilderModeService} from '../../builder-mode.service';
import {BuilderModeService} from '../../services/builder-mode.service';
import {ModelService} from '../../modeler/services/model/model.service';
import {SelectedTransitionService} from '../../modeler/selected-transition.service';
import {GridsterService} from '../gridster/gridster.service';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {SelectedTransitionService} from '../../modeler/selected-transition.servi
import {ModelService} from '../../modeler/services/model/model.service';
import {GridsterService} from '../gridster/gridster.service';
import {ComponentDef, FieldListService} from './field-list.service';
import {BuilderModeService, BuilderMode} from "../../builder-mode.service";
import {BuilderModeService, BuilderMode} from "../../services/builder-mode.service";

export interface Data {
title: string;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import {CUSTOM_ELEMENTS_SCHEMA, NO_ERRORS_SCHEMA} from '@angular/core';
import {ComponentFixture, TestBed} from '@angular/core/testing';
import {PetriNet} from '@netgrif/petriflow';
import {BuilderModeService} from '../builder-mode.service';
import {BuilderModeService} from '../services/builder-mode.service';
import {ModelService} from '../modeler/services/model/model.service';
import {SelectedTransitionService} from '../modeler/selected-transition.service';
import {FormBuilderComponent} from './form-builder.component';
import {BuilderIntegrationService} from "../builder-integration.service";
import {BuilderIntegrationService} from "../services/builder-integration.service";
import {HistoryService} from "../modeler/services/history/history.service";
import {HttpClientTestingModule} from "@angular/common/http/testing";
import {RouterTestingModule} from "@angular/router/testing";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ import {ModelerConfig} from '../modeler/modeler-config';
import {ModelerUtils} from '../modeler/modeler-utils';
import {SelectedTransitionService} from '../modeler/selected-transition.service';
import {ModelService} from '../modeler/services/model/model.service';
import {BuilderMode, BuilderModeService} from "../builder-mode.service";
import {BuilderIntegrationService} from "../builder-integration.service";
import {BuilderMode, BuilderModeService} from "../services/builder-mode.service";
import {BuilderIntegrationService} from "../services/builder-integration.service";

@Component({
selector: 'nc-builder-form-builder',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {NO_ERRORS_SCHEMA} from '@angular/core';
import {TestBed} from '@angular/core/testing';
import {Router} from '@angular/router';
import {BuilderModeService} from '../../builder-mode.service';
import {BuilderModeService} from '../../services/builder-mode.service';
import {ArcFactory} from '../../modeler/edit-mode/domain/arc-builders/arc-factory.service';
import {ModelService} from '../../modeler/services/model/model.service';
import {SelectedTransitionService} from '../../modeler/selected-transition.service';
Expand All @@ -10,6 +10,7 @@ import {ExportService} from '@netgrif/petriflow';
import {GridsterService} from './gridster.service';
import {FieldListService} from '../field-list/field-list.service';
import {GridsterComponent} from './gridster.component';
import {LocalStorageService} from "../../services/local-storage.service";

describe('GridsterComponent', () => {
beforeEach(() => {
Expand All @@ -24,6 +25,7 @@ describe('GridsterComponent', () => {
BuilderModeService,
HistoryService,
ExportService,
LocalStorageService,
{provide: Router, useValue: {}},
],
schemas: [NO_ERRORS_SCHEMA],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {ModelService} from '../../modeler/services/model/model.service';
import {FieldListService} from '../field-list/field-list.service';
import {GridsterDataField} from './classes/gridster-data-field';
import {GridsterService} from './gridster.service';
import {BuilderModeService, BuilderMode} from "../../builder-mode.service";
import {BuilderModeService, BuilderMode} from "../../services/builder-mode.service";

@Component({
selector: 'nc-builder-gridster-component',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {NO_ERRORS_SCHEMA} from '@angular/core';
import {TestBed} from '@angular/core/testing';
import {BuilderModeService} from '../../builder-mode.service';
import {BuilderModeService} from '../../services/builder-mode.service';
import {ArcFactory} from '../../modeler/edit-mode/domain/arc-builders/arc-factory.service';
import {ModelService} from '../../modeler/services/model/model.service';
import {SelectedTransitionService} from '../../modeler/selected-transition.service';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {Component} from '@angular/core';
import {PetriNet, Transition} from '@netgrif/petriflow';
import {SelectedTransitionService} from '../../modeler/selected-transition.service';
import {ModelService} from '../../modeler/services/model/model.service';
import {BuilderModeService, BuilderMode} from "../../builder-mode.service";
import {BuilderModeService, BuilderMode} from "../../services/builder-mode.service";

@Component({
selector: 'nc-builder-info-label',
Expand Down
Loading
Loading