fix(uploader): rename deleteCustomerHeader to deleteCustomHeader#2106
Open
skjnldsv wants to merge 2 commits into
Open
fix(uploader): rename deleteCustomerHeader to deleteCustomHeader#2106skjnldsv wants to merge 2 commits into
skjnldsv wants to merge 2 commits into
Conversation
Fix typo in public API method name. The method was incorrectly named `deleteCustomerHeader` (with an extra "r") instead of `deleteCustomHeader` to match its counterpart `setCustomHeader`. Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2106 +/- ##
=======================================
Coverage 36.30% 36.30%
=======================================
Files 17 17
Lines 774 774
Branches 145 145
=======================================
Hits 281 281
Misses 480 480
Partials 13 13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Contributor
Author
|
@susnux is this a breaking change? 🙈 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix typo in public API method name:
deleteCustomerHeader→deleteCustomHeader.The method had an extra "r" (
Customerinstead ofCustom), making it inconsistent with its counterpartsetCustomHeader.