Skip to content

fix(files_versions): Return if version entity is not found#55024

Closed
solracsf wants to merge 1 commit into
masterfrom
returnIfVersionForFileIdNotFound
Closed

fix(files_versions): Return if version entity is not found#55024
solracsf wants to merge 1 commit into
masterfrom
returnIfVersionForFileIdNotFound

Conversation

@solracsf

@solracsf solracsf commented Sep 11, 2025

Copy link
Copy Markdown
Member

Summary

Fix for:

{
  "reqId": "iNwhE8uZnaFbKbyG6WFq",
  "level": 3,
  "time": "2025-09-11T09:48:09+02:00",
  "remoteAddr": "91.6.26.13",
  "user": "fzez",
  "app": "no app in context",
  "method": "COPY",
  "url": "/remote.php/dav/files/user/folder/file.md",
  "message": "Exception thrown: OCP\\AppFramework\\Db\\DoesNotExistException",
  "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/137.0.0.0 Safari/537.36",
  "version": "30.0.14.1",
  "exception": {
    "Exception": "OCP\\AppFramework\\Db\\DoesNotExistException",
    "Message": "Did expect one result but found none when executing: query \"SELECT * FROM `*PREFIX*files_versions` WHERE (`file_id` = :dcValue1) AND (`timestamp` = :dcValue2)\"; ",
    "Code": 0,
    "Trace": [
      {
        "file": "/var/www/nextcloud/lib/public/AppFramework/Db/QBMapper.php",
        "line": 359,
        "function": "findOneQuery",
        "class": "OCP\\AppFramework\\Db\\QBMapper",
        "type": "->",
        "args": [
          {
            "__class__": "OC\\DB\\QueryBuilder\\QueryBuilder"
          }
        ]
      },
      {
        "file": "/var/www/nextcloud/apps/files_versions/lib/Db/VersionsMapper.php",
        "line": 60,
        "function": "findEntity",
        "class": "OCP\\AppFramework\\Db\\QBMapper",
        "type": "->",
        "args": [
          {
            "__class__": "OC\\DB\\QueryBuilder\\QueryBuilder"
          }
        ]
      },
      {
        "file": "/var/www/nextcloud/apps/files_versions/lib/Versions/LegacyVersionsBackend.php",
        "line": 254,
        "function": "findVersionForFileId",
        "class": "OCA\\Files_Versions\\Db\\VersionsMapper",
        "type": "->",
        "args": [
          204706,
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/var/www/nextcloud/apps/files_versions/lib/Versions/VersionManager.php",
        "line": 129,
        "function": "updateVersionEntity",
        "class": "OCA\\Files_Versions\\Versions\\LegacyVersionsBackend",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/var/www/nextcloud/apps/files_versions/lib/Listener/FileEventsListener.php",
        "line": 254,
        "function": "updateVersionEntity",
        "class": "OCA\\Files_Versions\\Versions\\VersionManager",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      {
        "file": "/var/www/nextcloud/apps/files_versions/lib/Listener/FileEventsListener.php",
        "line": 85,
        "function": "post_write_hook",
        "class": "OCA\\Files_Versions\\Listener\\FileEventsListener",
        "type": "->",
        "args": [
          "*** sensitive parameters replaced ***"
        ]
      },
      ...
}

Checklist

@solracsf solracsf added this to the Nextcloud 33 milestone Sep 11, 2025
@solracsf solracsf requested a review from a team as a code owner September 11, 2025 10:10
@solracsf solracsf requested review from Altahrim, CarlSchwan and sorbaugh and removed request for a team September 11, 2025 10:10
@solracsf solracsf requested a review from artonge September 11, 2025 10:16
@solracsf

Copy link
Copy Markdown
Member Author

/backport to stable32

@solracsf

Copy link
Copy Markdown
Member Author

/backport to stable31

@github-actions

This comment was marked as off-topic.

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf force-pushed the returnIfVersionForFileIdNotFound branch from 865235d to 049be10 Compare September 11, 2025 10:27
@github-actions

Copy link
Copy Markdown
Contributor

Possible performance regression detected

Show Output
An unhandled exception has been thrown:
TypeError: array_map(): Argument #2 ($array) must be of type array, null given in /home/runner/work/server/server/apps/profiler/lib/Command/Compare.php:35
Stack trace:
#0 /home/runner/work/server/server/apps/profiler/lib/Command/Compare.php(35): array_map()
#1 /home/runner/work/server/server/3rdparty/symfony/console/Command/Command.php(326): OCAProfilerCommandCompare->execute()
#2 /home/runner/work/server/server/core/Command/Base.php(218): SymfonyComponentConsoleCommandCommand->run()
#3 /home/runner/work/server/server/3rdparty/symfony/console/Application.php(1078): OCCoreCommandBase->run()
#4 /home/runner/work/server/server/3rdparty/symfony/console/Application.php(324): SymfonyComponentConsoleApplication->doRunCommand()
#5 /home/runner/work/server/server/3rdparty/symfony/console/Application.php(175): SymfonyComponentConsoleApplication->doRun()
#6 /home/runner/work/server/server/lib/private/Console/Application.php(187): SymfonyComponentConsoleApplication->run()
#7 /home/runner/work/server/server/console.php(91): OCConsoleApplication->run()
#8 /home/runner/work/server/server/occ(33): require_once('...')
#9 {main}

@artonge

artonge commented Sep 11, 2025

Copy link
Copy Markdown
Collaborator

Always hesitant with such fixes as it hides a logic flaw. Is the error linked to a specific operation?

@solracsf

Copy link
Copy Markdown
Member Author

@artonge COPY from one folder to another.

      {
        "file": "/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/CorePlugin.php",
        "line": 659,
        "function": "copy",
        "class": "Sabre\\DAV\\Tree",
        "type": "->",
        "args": [
          "files/BE8G/GT orientations/02_otes/Orientation 1/Accès au va.md",
          "files/BE8G/GT orientations/02_otes/Orientation 18/Accès au va.md"
        ]
      },

This was referenced Jan 7, 2026
This was referenced Jan 14, 2026
This was referenced Jan 29, 2026
This was referenced Feb 11, 2026
@blizzz blizzz modified the milestones: Nextcloud 33, Nextcloud 34 Feb 16, 2026
This was referenced Jun 5, 2026
@susnux susnux added the community pull requests from community label Jun 9, 2026
@susnux susnux removed this from the Nextcloud 34.0.1 milestone Jun 9, 2026

@salmart-dev salmart-dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to implement this kind of check in the hooks where this function is used, rather than ignoring a missing file here, as any user of the backend may want to know that the operation failed for some reason and react on that.

@solracsf

Copy link
Copy Markdown
Member Author

Superseed by #61202

@solracsf solracsf closed this Jun 11, 2026
@solracsf solracsf deleted the returnIfVersionForFileIdNotFound branch June 11, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request community pull requests from community feature: versions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants