fix(core): improve app icon contrast in the app menu - #62931
Open
pringelmann wants to merge 2 commits into
Open
Conversation
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
pringelmann
requested review from
kristian-zendato,
skjnldsv and
sorbaugh
and removed request for
a team
August 5, 2026 10:46
pringelmann
requested review from
Altahrim,
leftybournes and
salmart-dev
and removed request for
a team
August 5, 2026 10:46
Contributor
Author
|
/backport to stable34 |
pringelmann
requested review from
artonge,
kra-mo and
susnux
and removed request for
Altahrim,
salmart-dev and
sorbaugh
August 5, 2026 10:56
susnux
approved these changes
Aug 5, 2026
artonge
approved these changes
Aug 5, 2026
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
App icons in the waffle menu were hard to tell apart, so the colours are flipped: pale primary tint for the circle, saturated primary for the glyph. Shine and drop shadow are gone, circle and glyph are slightly bigger, and the circle scales on hover.
-> Preview link <-
The glyph is painted through a CSS mask. App icons ship a hardcoded fill, so
currentColornever applies and the oldfilter: invert()could only flip black and white, which is why an arbitrary theme color wasn't possible before.Examples:
Dark themes get no bevel. Their circle sits too close to black to darken any further, and mixing toward the primary brightened it into a glow instead.
New accessibility tests rebuild the lightest stop of both gradients and hold the contrast at 3:1 across default, dark and both high-contrast themes.
Other changes
AppIconis shared with unified search results, so app results there change too:Checklist
3. to review, feature component)stable32)AI (if applicable)