fmhfunprofiler: fix test data and update snapshot - #12417
Open
nickp60 wants to merge 5 commits into
Open
Conversation
mashehu
requested changes
Jul 24, 2026
| { assert process.success }, | ||
| { assert snapshot( | ||
| path(process.out.csv[0][1]).readLines()[1..10] | ||
| ).match() } |
Contributor
There was a problem hiding this comment.
Suggested change
| ).match() } | |
| { assert snapshot( | |
| path(process.out.csv[0][1]).readLines()[1..10] | |
| process.out.findAll { key, val -> key.startsWith('versions') } |
every test should also capture the version output
miraep8
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
I noticed that the previous test data was malformed, resulting in failure of one step of the tool; however the tool still outputs a file with a header, making it look like it was a success. Here I have fixed the tests as follows:
Closes #12416
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile condaI will change the path to the db in the tests from my personal once this PR for the data fix is reviewed and accepted.