Repository navigation
fix(atomic): validate en passant with variant rules - #1215
Open
0d00ciallo0721 wants to merge 1 commit into
Open
0d00ciallo0721 wants to merge 1 commit into
0d00ciallo0721 wants to merge 1 commit into
Conversation
0d00ciallo0721
marked this pull request as ready for review
October 6, 2026 08:40
0d00ciallo0721
force-pushed
the
agent-tasks/1214
branch
from
October 6, 2026 16:23
425d5e8 to
4ed069d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1214
Summary
AtomicBoardinheritsBoard.generate_legal_ep(), which only checks whether the capturing king remains in check. Atomic chess has two additional cases: capturing the opponent's king makes the move legal, while exploding the capturing king makes it illegal. UseAtomicBoard.is_legal()for en-passant generation, matchinggenerate_legal_moves().The regression coverage exercises both cases through
generate_legal_moves(),generate_legal_ep(),generate_legal_captures(),has_legal_en_passant(), FEN, and EPD.Verification
python3 test.py AtomicTestCase.test_atomic_en_passant --verbose— passed.python3 test.py— 296 tests passed, 22 skipped because optional chess engines/tablebases are unavailable locally.git diff --check— passed.AI assistance was used for issue analysis, the implementation, and regression coverage.