Conversation
A second destroy, or destroy on an instance that no longer owns the overlay, only releases that instance. The tour on the page keeps its popover, highlight, and body class. Fixes nilbuild#504
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #504.
destroy()on one instance was removing the shared overlay, body classes, and highlighted state for a newer tour. A delayeddestroy()from an old highlight could therefore close the tour that had replaced it.This patch keeps ownership of the page-level tour explicit. A stale instance releases only its own listeners and highlight; the current instance keeps its popover, overlay, body classes, and active highlight. An instance that never started, or was already destroyed, returns without touching the document. The same instance can start another highlight after a real teardown.
This PR stays focused on the stale-instance
destroy()invariant.setSteps()behavior is unchanged.Test plan
pnpm --dir packages/driver test:run(341 tests)pnpm builddestroy()after teardown leaves the replacement tour updestroy()while the old instance still reportsisActive()leaves the replacement tour updestroy()on an instance that never started leaves the live tour updestroy()Refs #504