Avoid std::copy calls that make 0 length copy, possibly reading from an invalid pointer (UBSAN issue) - #1627
Merged
Merged
Conversation
…an invalid pointer (UBSAN issue)
Contributor
Author
|
Three times testing failed on "Error in library(testthat) : there is no package called ‘testthat’". This seemed like a basic infrastructure issue with GitHub and/or CRAN, so I expected it to resolve itself when I restarted the test jobs, but it hasn't. @paciorek Do you have any ideas? |
Contributor
Author
|
Per suggestion from Claude AI, I cleared the cache. I also moved the Version and Date back to what they had been, after having modified them when trying to use |
Contributor
|
This confirms that running this branch under rhub using option 9 (clang-ubsan) resolves the issue. No error is printed when doing the |
Contributor
|
@perrydv ok for me to merge this in? |
Contributor
Author
|
yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attempts to the fix the latest CRAN UBSAN (non-)issue from code that has been working for years.
I'm having a hard time reproducing the original UBSAN issue so I haven't verified that this fixes it, but I think it should. In any case I'll run testing.
The changes are minor so there really shouldn't be a testing problem...