update handling of self=FALSE in getParents and use in setupMargNodes - #1633
Open
paciorek wants to merge 8 commits into
Open
update handling of self=FALSE in getParents and use in setupMargNodes#1633paciorek wants to merge 8 commits into
self=FALSE in getParents and use in setupMargNodes#1633paciorek wants to merge 8 commits into
Conversation
Contributor
Author
|
The test-ADforwardSolve failure seems to be a heisenbug. It is fine when I run it locally. |
Contributor
|
This looks like a tolerance issue, what has been a pain for AD testing and seemingly can arise for inscrutable reasons like R or library or OS or compiler versions. I'd suggest running tests on devel to determine if this failure arises from any changes to the CI testing setup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This combines the tentative work in PR #1630 and PR #1631 , plus removes what should be redundant calls to
setdiffinsetupMargNodes, now thatself=FALSEdoes omit all nodes that are provided as the input nodes togetParents.We are considering including this PR in version 1.4.3.
We are thinking that to do so we probably want to run all the extended nimDerivs testing not included in CI.