fix(skill): block transactional sends when deliverability signals are missing - #2
Open
Dinu-Senal wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transactional sends have no server-side approval gate, so a misconfigured account (sandbox domain, missing sender name, missing physical address, unverified domain) could send straight to spam with no warning.
send-transactionalnow runsnitro_get_statusbeforenitro_send_message / nitro_send_test_messageand stops to ask the user before proceeding if any signal is missing, instead of sending first and mentioning the risk after."Send anyway" only applies to the message just discussed, not to unrelated future sends in the same conversation.
I also attached what appears in terminal when user uses a misconfigured account

Testing
Manually verified via
claude --plugin-diragainst a deliberately misconfigured test account: confirmed the check blocks the send (not just a warning appended alongside it) and confirmed a second, different send request re-triggers the check rather than inheriting the first "send anyway."Scope
Scoped to
send-transactionalonly for this PR.send-campaignhas the same gap (its preflight check currently runs after the test send, not before). Happy to follow up there separately if this approach looks right to you.Open to a different pattern if you'd rather handle this server-side or via a hook instead of a skill instruction. Figured I'd propose the smallest version first.