Skip to content

jenkins: adjust OpenSSL exclusions#4386

Open
richardlau wants to merge 1 commit into
nodejs:mainfrom
richardlau:openssl4
Open

jenkins: adjust OpenSSL exclusions#4386
richardlau wants to merge 1 commit into
nodejs:mainfrom
richardlau:openssl4

Conversation

@richardlau

Copy link
Copy Markdown
Member

Run sharedlibs_openssl35 on Node.js 22 (test fixes were backported some time ago).
Add sharedlibs_openssl40, excluded for now on Node.js 22 (doesn't compile).

Refs: #4364
Refs: nodejs/TSC#1869

Run `sharedlibs_openssl35` on Node.js 22 (test fixes were backported
some time ago).
Add `sharedlibs_openssl40`, excluded for now on Node.js 22 (doesn't
compile).
@richardlau

Copy link
Copy Markdown
Member Author

Add sharedlibs_openssl40, excluded for now on Node.js 22 (doesn't compile).

https://ci.nodejs.org/job/richardlau-node-test-commit-linux-containered/nodes=ubuntu2404_sharedlibs_openssl40_x64/2/console

19:27:49 In file included from ../deps/ncrypto/ncrypto.h:4:
19:27:49 /opt/openssl-4.0.1/include/openssl/bn.h:379:5: note: declared here
19:27:49   379 | int BN_is_prime_ex(const BIGNUM *p, int nchecks, BN_CTX *ctx, BN_GENCB *cb);
19:27:49       |     ^~~~~~~~~~~~~~
19:27:49 ../deps/ncrypto/ncrypto.cc: In function 'bool ncrypto::{anonymous}::PrintGeneralName(const ncrypto::BIOPointer&, const GENERAL_NAME*)':
19:27:49 ../deps/ncrypto/ncrypto.cc:646:57: error: invalid use of incomplete type 'ASN1_IA5STRING' {aka 'struct asn1_string_st'}
19:27:49   646 |     PrintAltName(out, reinterpret_cast<const char*>(name->data), name->length);
19:27:49       |                                                         ^~
19:27:49 In file included from /opt/openssl-4.0.1/include/openssl/crypto.h:38,
19:27:49                  from /opt/openssl-4.0.1/include/openssl/bio.h:32,
19:27:49                  from ../deps/ncrypto/ncrypto.h:3:
19:27:49 /opt/openssl-4.0.1/include/openssl/types.h:57:16: note: forward declaration of 'ASN1_IA5STRING' {aka 'struct asn1_string_st'}
19:27:49    57 | typedef struct asn1_string_st ASN1_INTEGER;
19:27:49       |                ^~~~~~~~~~~~~~
19:27:49 ../deps/ncrypto/ncrypto.cc:646:70: error: invalid use of incomplete type 'ASN1_IA5STRING' {aka 'struct asn1_string_st'}
19:27:49   646 |     PrintAltName(out, reinterpret_cast<const char*>(name->data), name->length);
19:27:49       |                                                  
...

Further to that, nodejs/node#62410 doesn't apply cleanly on v22.x-staging and looks non-trivial to fix up (it might need some of the missing ncrypto updates and I'm not sure if all of those are safe to apply).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants