jenkins: adjust OpenSSL exclusions#4386
Open
richardlau wants to merge 1 commit into
Open
Conversation
Run `sharedlibs_openssl35` on Node.js 22 (test fixes were backported some time ago). Add `sharedlibs_openssl40`, excluded for now on Node.js 22 (doesn't compile).
Member
Author
19:27:49 In file included from ../deps/ncrypto/ncrypto.h:4:
19:27:49 /opt/openssl-4.0.1/include/openssl/bn.h:379:5: note: declared here
19:27:49 379 | int BN_is_prime_ex(const BIGNUM *p, int nchecks, BN_CTX *ctx, BN_GENCB *cb);
19:27:49 | ^~~~~~~~~~~~~~
19:27:49 ../deps/ncrypto/ncrypto.cc: In function 'bool ncrypto::{anonymous}::PrintGeneralName(const ncrypto::BIOPointer&, const GENERAL_NAME*)':
19:27:49 ../deps/ncrypto/ncrypto.cc:646:57: error: invalid use of incomplete type 'ASN1_IA5STRING' {aka 'struct asn1_string_st'}
19:27:49 646 | PrintAltName(out, reinterpret_cast<const char*>(name->data), name->length);
19:27:49 | ^~
19:27:49 In file included from /opt/openssl-4.0.1/include/openssl/crypto.h:38,
19:27:49 from /opt/openssl-4.0.1/include/openssl/bio.h:32,
19:27:49 from ../deps/ncrypto/ncrypto.h:3:
19:27:49 /opt/openssl-4.0.1/include/openssl/types.h:57:16: note: forward declaration of 'ASN1_IA5STRING' {aka 'struct asn1_string_st'}
19:27:49 57 | typedef struct asn1_string_st ASN1_INTEGER;
19:27:49 | ^~~~~~~~~~~~~~
19:27:49 ../deps/ncrypto/ncrypto.cc:646:70: error: invalid use of incomplete type 'ASN1_IA5STRING' {aka 'struct asn1_string_st'}
19:27:49 646 | PrintAltName(out, reinterpret_cast<const char*>(name->data), name->length);
19:27:49 |
...Further to that, nodejs/node#62410 doesn't apply cleanly on |
sxa
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run
sharedlibs_openssl35on Node.js 22 (test fixes were backported some time ago).Add
sharedlibs_openssl40, excluded for now on Node.js 22 (doesn't compile).Refs: #4364
Refs: nodejs/TSC#1869