module: add module.entrypoint - #64903
Open
mcollina wants to merge 2 commits into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
module
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64903 +/- ##
==========================================
+ Coverage 90.13% 90.30% +0.17%
==========================================
Files 746 759 +13
Lines 242893 247629 +4736
Branches 45769 46683 +914
==========================================
+ Hits 218935 223631 +4696
- Misses 15444 15459 +15
- Partials 8514 8539 +25
🚀 New features to boost your workflow:
|
avivkeller
approved these changes
Aug 1, 2026
jasnell
approved these changes
Aug 2, 2026
Member
|
@mcollina lint? |
jsumners-nr
approved these changes
Aug 3, 2026
Add `module.entrypoint`, a property exposing the resolved URL of the entry point of the current thread. Unlike `require.main`, it works regardless of whether the entry point is a CommonJS or an ECMAScript module, and inside worker threads it reflects the entry point of the worker itself, matching the semantics of `require.main` and `import.meta.main`. Refs: nodejs#51840 Refs: nodejs#64800 Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina
force-pushed
the
module-entrypoint
branch
from
August 3, 2026 13:35
b6075b5 to
d5b61b2
Compare
richardlau
added
the
semver-minor
guybedford
approved these changes
Aug 4, 2026
avivkeller
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
aduh95
reviewed
Aug 4, 2026
Comment on lines
+14
to
+18
| function fixtureURL(...args) { | ||
| // The entrypoint is fully resolved, so account for symlinks in the path | ||
| // to the fixtures directory. | ||
| return pathToFileURL(realpathSync(fixtures.path('module-entrypoint', ...args))).href; | ||
| } |
Contributor
There was a problem hiding this comment.
Why not use fixtures.fileURL?
aduh95
reviewed
Aug 4, 2026
aduh95
reviewed
Aug 4, 2026
Comment on lines
+96
to
+100
| import { entrypoint } from 'node:module'; | ||
|
|
||
| if (import.meta.url === entrypoint) { | ||
| console.log('This module is the entry point of the current thread'); | ||
| } |
Contributor
There was a problem hiding this comment.
That's not a great example, import.meta.main would be a much better choice here – and if we can't find a good example, do we actually need that API?
Member
Author
There was a problem hiding this comment.
because import.meta.main only returns true if it's the current one, but don't report us what's the actual "entrypoint" of the current thread/module chain. So it's not easily discoverable.
The same can be said for #64800.
If you want I can remove the example.
Contributor
There was a problem hiding this comment.
Yeah I think the example either needs to include import.meta.main, and/or process.mainModule (to explain the diffs and show some actual use-cases) otherwise it looks like we're adding a less elegant way to do something that's already possible
panva
approved these changes
Aug 5, 2026
Address review feedback from aduh95. Signed-off-by: Matteo Collina <hello@matteocollina.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
module.entrypointtonode:module: the resolved URL string of the entry point of the current thread.The semantics follow
require.mainandimport.meta.main(thread-scoped): inside a worker thread it is the URL of the script the worker was started with, not the entry point of the process. This complements #64800, which exposes the process-wide entry point inherited by workers.undefinedfor--eval, the REPL, STDIN input, andeval: trueworkers; set to thedata:URL for data URL workers.--preserve-symlinks-main), so it matchesrequire.main.filename/ the entry point'simport.meta.urlrather thanprocess.argv[1].Refs: #51840
Refs: #64800