sqlite: use cached strings for property keys - #65902
Open
kyungrae2002 wants to merge 1 commit into
Open
kyungrae2002 wants to merge 1 commit into
kyungrae2002 wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65902 +/- ##
==========================================
- Coverage 90.38% 90.37% -0.01%
==========================================
Files 790 790
Lines 274497 274488 -9
Branches 52557 52559 +2
==========================================
- Hits 248100 248076 -24
Misses 16879 16879
- Partials 9518 9533 +15
🚀 New features to boost your workflow:
|
addaleax
approved these changes
Sep 25, 2026
Collaborator
Contributor
|
This pull request has conflicts with its base branch, removing the |
Signed-off-by: Kyungrae Kang <kyungrae2002@gmail.com> Assisted-by: Codex
kyungrae2002
force-pushed
the
sqlite-use-cached-property-strings
branch
from
September 26, 2026 10:18
551eeb6 to
bcae997
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use strings cached in Environment when accessing commonly used node:sqlite property keys.
Replace
FIXED_ONE_BYTE_STRING()calls in the SQLite bindings with the corresponding strings cached by Environment.This avoids creating the same V8 strings at each call site and makes the SQLite binding consistent with other Node.js core modules that use Environment string getters.
No intended behavioral changes.