Conversation
Test mode reduces bufferSize to one, giving the random buffers a 1/256 chance of matching and failing the comparison count assertion. Use 256 bytes in test mode and force the first bytes to differ before timing. Remove the flaky designation. Fixes: nodejs#52690 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
Native debug writes can be lost when the non-blocking stderr pipe fills, leaving expected log lines missing even when the child exits successfully. Capture stderr in a temporary file and apply the existing assertions to its contents. Remove the flaky designation on Linux s390x. Fixes: nodejs#58353 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Codex
panva
added
flaky-test
Collaborator
|
Review requested:
|
nodejs-github-bot
added
benchmark
panva
force-pushed
the
deflake-crypto-http2
branch
from
September 20, 2026 07:23
0f0994a to
83f9059
Compare
Member
Author
|
main: https://ci.nodejs.org/job/node-stress-single-test/897/ 🔴 (i think i set these up right, ...) |
panva
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66151 +/- ##
==========================================
- Coverage 90.29% 90.27% -0.02%
==========================================
Files 790 790
Lines 272021 272021
Branches 51917 51921 +4
==========================================
- Hits 245611 245572 -39
- Misses 16903 16943 +40
+ Partials 9507 9506 -1 🚀 New features to boost your workflow:
|
panva
added
the
commit-queue
jakecastelli
approved these changes
Sep 20, 2026
panva
added
the
fast-track
Contributor
|
Fast-track has been requested by @panva. Please 👍 to approve. |
jasnell
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure the timingSafeEqual benchmark's random buffers differ and use 256-byte buffers in test mode. The default one-byte buffers could match and fail the comparison count assertion.
Capture HTTP/2 debug output in a temporary file. Native log messages can be lost when the non-blocking stderr pipe fills, causing assertions to fail even when the child exits successfully.
Remove both flaky designations.
Fixes: #52690
Fixes: #58353