test: deflake test-bench-errors

[panva]

The 10ms timeout can expire before the benchmark callback starts. There is then no unsettled work to abort the rest of the run.

Abort from inside the callback to guarantee pending work. Cover timeout errors separately with a zero timeout.

[panva]

main: https://ci.nodejs.org/job/node-stress-single-test/898/
PR: https://ci.nodejs.org/job/node-stress-single-test/899/

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.29%. Comparing base (97af3d7) to head (050b8ba).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #66153   +/-   ##
=======================================
  Coverage   90.29%   90.29%           
=======================================
  Files         790      790           
  Lines      272021   272021           
  Branches    51917    51930   +13     
=======================================
+ Hits       245611   245626   +15     
+ Misses      16903    16889   -14     
+ Partials     9507     9506    -1     

see 22 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[panva]

Locally, I forced the timing window with a beforeEach hook that blocks for 25ms using Atomics.wait() before the timeout benchmark.

That lets its 10ms deadline expire before the callback starts. There is then no unsettled work, so the following benchmark runs and its mustNotCall() produces ERR_ASSERTION instead of the expected ABORT_ERR like in:

• https://github.com/nodejs/node/pull/65970/
• https://github.com/nodejs/node/pull/66093/
• https://github.com/nodejs/node/pull/66111/

The unmodified test failed with the reported assertion in 100/100 forced runs. With this fix 100/100 runs passed with the same delay applied.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/77672/

[github-actions]

Fast-track has been requested by @panva. Please 👍 to approve.